 Hello everyone, so welcome to just sync up call about acceptance test harness and Java 11 so between many people here so last week we met and so we are just going to make a quick sync up about that just to provide some context from the previous meeting we should even have meeting notes somewhere just a second I'm looking for the document so for people watching basically there is an ongoing effort led by mainly Oleg about making Jenkins compatible with Java 11 and so one of those items are to make sure the acceptance test harness so called ATH the Selenium based test framework for Jenkins is also made compatible with Java 11 basically I've put the link to the document from the previous session to Jenkins Rc and I'll duplicate it to the platform sync channel right now so I propose to just continue with the document we had before and have it for multiple sync ups so that we don't create more entities that are needed sure I think it's a good idea want me to share the screen so that we all feed the document or something yeah you could do that it would be great so actually it was about doing the same but I was handling things Robin thank you I'm trying to clean up my screen that's fine let's go or that one maybe you should see now my screen and I'm going to make it bigger right see the notes document I'm just creating a section in the bottom four to be so last time we met on Friday in order to discuss the statuses and coordinate on the efforts we had some pull-ups like one of the major things that Oliver and the Red Car team they have already launched acceptance test harness against Java 11 so that we should probably have some results by now but we know that there are some pitfalls there like pipeline compatibility and maybe other things so it would make sense to sync up to understand how did it go and how we operate in order to integrate changes needed to run the full test suite on Java 11 and certainly provide update on that so maybe we can start from there yeah definitely so in the meantime we managed to get a couple of healthy runs I briefly compared a number of failures and a test that are failing and there appears to be just one more extra test failing for Java 11 after we have integrated the fix for workflow support plugin and we didn't even need to add any of the model overrides so this is where we are right now I started going through the individual problems and fixing them as I find them because sometimes the tests are failing for different reasons so there's like I don't know like 60 tests to go through to actually validate them so this is what we will be doing in the upcoming days yeah so but is by the way I give you edit permissions to the document as well to Oliver thank you yeah so we have one regress test and we had about 60 failing tests but yeah we use a certain test harness some tests fail every time which we cannot so have you executed the full test suite on the particular categories what I have running and I guess I'll try to attach that here is we have full run of 88 that actually runs both Java 8 and Java 11 side by side so let me attach that to the doc and just to check did you say you were working also on the MSI installer or something no that's not what I mentioned okay I thought I heard MSI so I was thinking something about it so Alex is working on MSI installer because it's a story we are going to hit in January I believe and there was a report yesterday in Jenkins Jira that we actually bundle Oracle JDK now instead of even open JDK but yeah it's a simple story I just wanted to make sure I didn't misunderstand okay but anyway it's great to see that it's running and the results are really optimistic I believe that current acceptance test harness test suite doesn't include a blow ocean acceptance test harness because it's a separate beast so it's a separate repository which we do not run for common LCS flow if I recall correctly yeah those are separate you're right I guess did you give permissions to Oliver I think Alex so maybe Oliver you just have to refresh your brother or something so that you are not in suggest mode anymore right I tried a couple of times yeah it works now thank you okay that's cool by the way but please you haven't pinned your screen screen it seems so every time somebody else talking we will focus on the video the previous platform signal so now it should be better yeah now it should be better anyway it's a nice progress so one of the questions is how do we productize it going forward because we still need to integrate it into Jenkins pipeline I believe so that we enable acceptance test harness run for Jenkins core for example and there is still a number of patches needed to do that for example docker image and probably all environment settings because you need to pass models etc in order to get a certain sense harness working so what's your vision about that well I guess from the last time there is a couple of leftover items for us one of them is bumping the version of ATH it's running as a part of core PR tests and perhaps even integrating the test for Java 11 so I guess those are the next things to get running to see some real progress and in parallel I would like to work on polishing the test filters of ATH itself bump ATH in Jenkins core and the next one is here so Jenkins core doesn't use run ATH now if I recall correctly but we still need to run ATH update on the acceptance test harness side itself do you expect any additional fixes I mean with the current scripts it should be running out of the box on CI but I believe we still don't have a flow for local run I would say so as I said I didn't have the chance to evaluate all the test filters but I really believe that those are test filters and not really a framework filter so I'm pretty confident it's not going to be a problem Roman how's it going on your side? sorry Alec how's it going on your side? but at all I have same errors I think setting up environment due to the Firefox version I think difference between the Jenkins file how it built the Docker image container how it runs when I run the scripts the problem is that these failures I don't know exactly are due to the Java 11 or are due to the environment itself so now yesterday evening afternoon and today I'm going to compare the executions between Java 8 in my local environment the Java 11 in the Docker container to try to classify all the failures in Java 11 failures or just environment due to my laptop I'm not helpful so far due to that that's my contribution so far right just a very short follow up on that please know that it's pretty tricky to keep the Firefox instance with Selenium that's at least how it's been for number two and that's the reason why we have the container so for a long time we've been determined to use the container basically none of us has the compatible Firefox version with what Selenium expected much less about having everybody compatible Firefox so I don't think that you have to try very hard to get it working in a native environment as long as you are able to get yourself productive inside the container just do that I was sure that Selenium 3 resolved this issue because one of the main blockers probably not okay that's never ending battle anyway I'm going to write that that's summarizing what we said I guess okay so I guess this is mostly done anything else we should cover you think people I think we need to coordinate the effort a bit because if there is a public test result we need to check maybe we should start from checking the test results there and then checking local Java 8 run we already have reference results produced on the HCI instance could we yeah right so just could we or should we maybe like start to an image thread or for that because on our side right now it's a Ramon that's working on that right so Ramon maybe with an image thread where we are maybe Oliver and maybe more people on the other side trying to coordinate or maybe not doing kind of exactly what Ramon you were doing but you know focusing on some given test because Oliver is already probably ahead of us in some cases so that we don't duplicate efforts and we try to actually coordinate as Oleg is saying I agree it would be the waste of time if we redo things that Oliver has already I run out I guess what do you think how would you think Ramon about trying to better understand where Oliver is right now and trying to build on that basically okay I think a good proposal I need to sing with him what do you think Oleg that's perfectly fine with me when we started meetings on Friday and this was the main idea to synchronize but Oliver did a lot of progress over the weekend and maybe we need to catch up I guess maybe the right way to do that because Oliver is leading here because he's been a lot ahead of us Oliver where do you think you would welcome help I guess that would be the bottom line right as I said there's probably two things you would like to do in parallel I guess you know since we've been maintaining ATH for a while we have an advantage against all of you right since we're already productive with a tool so my suggestion would be that we narrow down that part and there's one thing we have successfully finished we have merged a built plugin pipeline library step so we have it right now I don't know where we are with deploying it but one of the things I believe it would be worth doing is actually trying to convert some plugins to use it to verify that pipeline code is right and that some plugins actually build against Java 11 the way we intended yeah I already started patching my plugin label verifier because we have a reference Java 11 branch there so I hope to submit it today cool do I understood you correctly that the pipeline changes are already deployed to CIG in Canxio they deployed once they integrated cool we have continuous delivery for this pipeline library which kind of frightens me since we have zero test automation but yeah I'm trying to summarize what you said I think it's it's probably huge it's a built plugin yeah you're right that that's all I think I cannot summarize it but I guess it's maybe not very understandable for anyone outside of us but I guess that's fine yeah so maybe so to summarize to try and clarify if need be Ramon could maybe better spend time working on let's say critically important plugins I guess like so Git I think maybe is already done or maybe not good things to adapt or to try to use ATH there would it make sense maybe for instance ATH for Git is added as a part of Essentials test flow so if you open Git Jenkins file you may see that there is already an invitation of ATH there right right right this is one of the only plugins which actually has acceptance test harness run integrated yeah yeah definitely and now I remember that was the one indeed where basically raw user as a playground and more than that before it reached the usable state so yeah basically I guess trying to identify the biggest plugins because apart from Git there's a few of them and focus on having them run on ATH in CI basically that would be interesting use of time I guess maybe where basically do you have an idea Oliver what is the plugin that you think would be the most important one maybe after Git or whatever well I have no strong preference as long as I know there is a couple of this support Java 11 branches for different plugins so I guess that's something that might be interested in switching to this new way of invocation and other except for that I would probably start with those pre-installed by you know the pre-installed by Jenkins right and other focus for us could be pipeline plugins because we know that there are still risks around pipeline with dependencies so if we speak about Jenkins test harness Jenkins test harness is generally covered by plugin compatibility tester and there is an open task to do some exploratory testing as a part of weekly J availability task for acceptance test harness yep for acceptance test harness we don't have specific tasks because we rely on the test run sorry I'm lagging behind with right keynotes another potential task would be to try running Blowshina ATH but here Blowshina ATH may be complicated because it uses acceptance test harness engine but in addition to that it uses whatever Node.js engine I agree but at the same time it's such a different beast that I think at least we would need probably some Blowshina developer so that it's actually feasible because I guess it's a bit specific and I'm not even sure how to start this but yes it would make sense from an overall picture standpoint but yeah do we have an idea who maintains the Blowshina ATH? I have no idea this is actually built on top of ATH well it there are some Java tests which are built on the top of ATH at least multi-linear part so it doesn't feel the command can work much who maintains that I can answer that yes so we have a team of contributors focusing on Blowshina and they maintain it the last update at 12th of May 2017 so yeah probably we have a problem there yeah and I guess we should find a way to run Java 11 without blocking PR like just informative and not breaking PR builds and everything I think they wouldn't like it at that stage at least but if then it's green then it's fine I guess we are trying to at least at least we can at least start the initiative because at some point it will need to be at least asked about we can ask the team, the Blowshina team about how to work to move forward about that I guess okay so Oliver, your Chetan plan is to just continue checking concept and test harness results that's right okay they believe that we should just take the topic on our side and see what we need to patch now to just get ETH adopted in other flows like Essentials test so you probably will just get it together offline and then as Baptiste suggested we can start a thread maybe in platform seek I'm not sure whether it's comfortable for you but it may be the best way or maybe just chat in Gitter Oliver? yeah that makes sense to me okay and then platform seek Gitter for the sync up okay for anyone watching, Oleg is talking about this yeah I'll post the link somewhere I'll log the document, okay press it in the bottom what? that's weird anyway so I will just, that's weird okay now it's platform seek I know but for some reason I was logged in okay right and so here and so that's the place and there is also for anyone watching the special interest group that's also existing you know outside of it basically that's an initiative in the Jenkins project so thanks everyone I think we are done with the sync up anything else before we stop the broadcast and leave I guess no I guess not thanks everyone and see you next time, bye