 Water-splitting electrolysis is a promising pathway to produce hydrogen efficiently. Catalysis or electrocatalysis plays a crucial role in this process. Active, stable, and low-cost catalysts are needed to achieve the desired electrocatalytic hydrogen production from water-splitting for practical use. This review discusses recent advances in the design and preparation of nanostructured noble metal and non-noble metal-based electrocatalysts for increasing the electrocatalytic activity and stability in both the hydrogen evolution reaction, HER, and the oxygen evolution reaction, OER. Future challenges and perspectives in the design of active and robust electrocatalysts for HER, and OER towards efficient production of hydrogen from water-splitting electrolysis are also outlined.