 All right everybody, good day. This is Andrew Connell. I'm sorry, I guess technically it's the second of our live streams that we're doing. But what I wanted to do is last week I did a dry run of this and this week I've spent a little bit more time like actually we're finding the process and stuff. And I'm looking forward to doing this again today or at least again doing it the first time I guess is for most of you are seeing this. And I'm looking forward to sharing with you like how this whole thing, you know, sharing with you this process and stuff. So this is my first kind of like live stream in a sense. And broadcasting this over to the Voitanos Facebook page as a Facebook live and I'm also doing it on the YouTube page as well. And the reason what I wanted to do with this is that I get a bunch of questions from people. Let me first kind of explain like what the idea here is behind the topic of what we're gonna cover today. I called this the behind the scenes of like processing pull requests and issues in the SP DevDocs issue list. And so one of the roles that I serve, that I myself serve with the patterns and practices core group is that I triage and I process a lot of the pull requests and issues that come from the SP DevDocs repository. This is the primary repository for all things SharePoint development related. So developers can come here and they can ask questions, submit bugs, submit documentation updates as well as pull requests to update and to make modifications to the documentation. And in addition to that, all comments that are left on the developer docs for the SharePoint developer docs on docs.microsoft.com, they all are added as issues to this issue list. So everything kind of goes here that SharePoint developer related. So what I want to do today is I want to kind of show you what my experience is like as one of the people responsible for, I don't know how you want to say it. I like to refer to it as babysitting, but it's also like maintaining and triaging and cleaning up all this stuff with the issue list. So before we get started though, I thought it would be a good idea to kind of take a second here and kind of just introduce myself real quick. So my name is Andrew Connell. I'm a SharePoint MVP or Microsoft M365 MVP. And I've been doing this now for like 15 some odd years. And like I said, one of the roles that I serve on the Patterns and Practices group, well, it seems like everybody else on Patterns and Practices, they own a project of something like the Office 365 CLI or stuff like that. I don't own anything like that. I don't own a project. Instead, I spent a lot of my time on the documentation, updating the docs, creating new articles, cleaning up the docs, and then also triaging the issues that come into the issue list. So the issue list that we're gonna spend time looking at today, you can see that if you go to aka.ms slash spdev-issues, that's gonna take you to the issue list. So what I wanna do is I wanna switch over, let's jump over to a demo. And let's take a look here at what the issue list looks like and the stuff that we have here. Now, what I wanna do is I kinda wanna run through a couple things before we do this. Now, one of the things that I do every, a couple times a week, I'm gonna jump over here to the task management thing that I use. So this app here, this is a think of this like my little to-do list. This is what I use to maintain tasks for my business and different work related things. And I have this task that is set up as a recurring task and it actually shows up once every three days. I think it's like Monday, Wednesday, Friday is when it shows up on my list. And it's just a reminder of things that I need to run through. We're gonna run through these. I'm gonna run through a couple of these. I'm just gonna show you what this experience is like. And, but before I do that, I kinda wanna give you a little bit of an overview of the issue list. You can kinda see some stuff that's in there. So, if I come over here to the issue list here, I've got a bunch of issues. And I've got a couple that I've already singled out that I wanna highlight for you that I think are good examples of either a good issue or a bad issue. And what I mean by bad issues, I mean like, this role that I serve and a lot of people serve in this issue list, this is not the primary like support vehicle for Microsoft in terms of SharePoint developers, right? The way that's done really is you have to have a support contract with Microsoft. If you've got a developer problem, you need to have a support contract. And what this is, think of this more as like community-based help, okay? When you do this, I know we've gotten pushback on this when I've said this in the past, but I really hope that people can understand what we mean by this. If when someone submits an issue and somebody is taking the time to try and help you, think about it that the easier I can make your job to help triage the problems that I'm having, the better that you can do, the better you can do with this, the better that, let's see, the better that you can make my life and make it easier for me to help you, the more inclined I am to be able to help. And so what I mean by that is, if I've got to sit there and look at what you've submitted, you just give me an issue that says, like, does not work right here, like this one that you see, right? So this one says does not work after days of banging my head against the wall, I followed the instructions to the letter, but it simply does not work. There is absolutely nothing to go on here, all right? So the docs have, the only reason the docs were published is because the article worked at the time. So it seems to me that this is, and because this is like, we don't see this a lot showing up, seems to me that this individual just is having a problem getting their stuff to work, but there's absolutely zero context around this, there's zero code that's been provided, there's zero screenshots, there's zero errors, what doesn't work, right? We don't know what works with this. I mean, they could simply say, I'm trying to type this into my iPad using a text editor or something like that, and it's not working. It's not the context. So like for an issue like this that we would see, we come in and we already see somebody has already said, please provide issues you're facing. I'm gonna go in and I have a comment that I've already created here. I'm gonna go ahead and copy this, and nope, that's not what's supposed to happen. Copy, oh, I see what it's doing. There, now. So I'm just putting a comment here. It says, you haven't probably enough information to assist without some context, or reproduction steps, screen captures, or there's not much we can do to help you. And so what I'm gonna do with this is I'm gonna go ahead and leave it as, I'm gonna drop the comment in, but then I'm gonna come over here and modify the labels. So I'm gonna remove the triage, and I'm gonna say this needs context and detail, and we can tell that because of the page they posted it on it's related to the SharePoint frameworks, I am gonna go ahead and categorize it as a general SharePoint framework question that shows up. So what's gonna happen here? So we have a bot that runs behind the scenes, and you see another label was just added to this guy. What this did, we have a bot that runs behind the scenes. It was watching that I put the label of context detail, and what it does is it's added in an extra bit of text here that basically is telling them, you gotta help us out here. You gotta give us more info than what you've given us, because there's not much we can do to help you with this. What that will do is that also adds the author needs feedback. Now what this is gonna end up doing is it's gonna, if the user has email notifications turned on in GitHub on their account, they'll get an email with this, and it's effectively going to start a timer, a 14-day timer. They've got seven days to respond, right? We don't want the issue list to be cluttered with a bunch of stuff that's just, people have asked a question and then they never come back and follow up. If you ask a question and you never follow up, we come back to you and try and help you and then you never respond to us, there's nothing to go on. So we might as well just delete the issue or close the issue. But, so what we do here is that we start this timer, and this bot that Rahan's behind the scenes says, I'm gonna give you seven days to respond. And if you don't respond with this author feedback on here, another label will get, another comment will be added with another label that says no recent activity. That effectively is saying, stale issue, man. I mean, if this is stale, you haven't done anything to help us. So what we're gonna end up doing is we're gonna go for another seven days and if you don't respond, we're simply gonna close the issue and just say, look, if you really have a problem and you want us to engage, you gotta play the game, right? In a sense, both sides have to be helpful here. And that timer will get abandoned if the original poster of this issue responds. If they respond at any point during that 14-day window, then the author feedback will get removed and that timer just goes away, all right? So nothing is gonna end up happening with that. So that's one way we keep this issue list kind of clean and keep people from getting this thing all messy. Let me come back over here. Let me show you what I do, one of the things I do with this and see this link here where it says needs triage. So I'm gonna go ahead and open up a tab for needs triage and I want you to see like what this does. So when a new issue gets created, if it gets created by someone coming to this issue list and clicking on new issue or if they've added a comment from the docs, any new issues that get added to this list are gonna get flagged or tagged with needs triage, okay? And so what that does when it says needs triage, that's going to get filtered. Basically it tells somebody like me that someone needs to take a look at this and somehow categorize it or do whatever. Now, one common misconception that people see with this, actually let me say one more thing before I do that. If it was a comment that was left from the developer documentation at docs.microsoft.com, it'll also get this label of docs comment, okay? Now, one common misconception that I see, that I see at least because I'm the one that does most of this stuff and triaging these items that come in is that some people think that I'm gonna answer every single question that comes in and that's simply not gonna happen. My sweet spot is SharePoint Framework stuff, maybe REST API stuff. I don't wanna enumerate all the things that I feel like I've got a strong background on but I have a strong background in specific areas and those are the areas that I focus on with the issue list and responding. However, I can at least identify what all these different, what the different things are that show up in this list and I can add specific categories to it or flag it if it's a question or something like that. So, let me see if I have any here that I wanted to highlight. Let's see, this one right here. So, this one where it says rendering a custom web part is not happening between the navigation of two pages. So, let me open up another tab with this. And what this issue is, this is somebody who is, has basically, I'll give you a quick summary of it but they have a web part, they put it on a page and then they wanna be able to jump between, they wanna be able to navigate with this web part being on multiple pages and they go from one page to next page to next page and they're having a trouble with the web part is not like the page lifecycle is not or the web part lifecycle is not being consistent with them. Like, sometimes it's doing the on a knit, sometimes it's not doing, it's doing the on dispose, sometimes it's not. It seems to me like it's a page router issue. Let me get my, I have my notes here and one note and of course one note is saving these, pasting my notes here as, it's pasting my notes here as images and so my responses aren't coming across correctly. So what I'm gonna do here is I have this response that basically came back to them. I wrote this up previously, so I'm saving you guys from the time but effectively I'm just, I'm saying, to me it smells like you're running into an issue with something called the page router so I explain kind of what that is and then I have a couple other questions related to it and so what I'm gonna do is I'll go ahead and I'm gonna drop the comment here because I can tell us a SharePoint framework. I'm then gonna come over here to the labels here. I'm gonna remove triage and I can tell this is a SharePoint framework question and I'm just gonna leave it as a, and also gonna have a needs follow-up here. Need some feedback here because I did have a question for them like saying what exactly are you trying to do? And so what that will do is that's expecting this person to come back and say, help, let me know what this is. They did flag this question as you can see at the top. They did flag it as a bug but not really sure if it really is a bug or not yet. I'm just asking another question here but I'm not gonna go through and flag it or add a label that says it is a bug or it is not a bug just yet. We got other issues here that I wanted to highlight so like what is this one I wanted to highlight? 5591, so this is a good one. So another thing, another one of the issues I have or one of the things that I do is on a weekly basis, let's say if someone came in and let's say a couple of days ago I went and I looked at this issue and I, which I did, scroll down here, I came back and I was like, there wasn't no issue while ago, check the version that you're doing and then I added that author needs feedback that you see right here. That's all fine and good. The author needs feedback thing is all fine and good but a little bit farther down, they did respond but to me they, so when they responded what it did was, remember what I said earlier it removes the author feedback label and then it adds in the needs attention label and so what that means, what I can do when I use that needs attention is that if somebody's responded, one of the things that I do is I go back and look for updates where people have responded, we've asked them to respond and they have responded. Now it may not be me that asked them to respond, maybe somebody else, but regardless they were asked to respond, they've responded and maybe it's something that I can go back and I can address or it's a good highlight for somebody else. So in this case here, they had some stuff that they said that they went in, they gave me some stuff, I was like, you still gotta give me more context, you haven't told me about the prompts. Now what I mean by this about these prompts is that if I come over here and I create a new issue, so this person had created an issue, so they did that by coming over here and clicking on the new issue link and what this button does is it takes you to a form where you choose one of the different types of issues you can create. Now this issue list is for developer issues, right? Developer issues, developer questions, developer issues. So if you come in and you're trying to ask a question about the docs or something, what we do is we try and like guide you in specific places if this is not the right place for you. So for example, with this one, if I'm looking for a question related to developer documentation, then I'm gonna send them over to the docs. If I've got somebody else, like let's say I've got this one about tech community, if you submit a question here that is not developer related to SharePoint, like for example, if you send me a developer question related, if you send, sorry, not me, if you send the issue list, submit an issue, a developer question related to Azure or Microsoft Graph, or if it's related to, and I mean specifically related to those things, like I mean there's obviously overlaps with stuff, but if it's not SharePoint developer related, and it's like an end user issue, or it's a administrative issue or configuration issue, we're gonna flag it as it's not a developer issue, and that'll automatically close the issue because we can't do anything about that here in this issue list. And I know it seems kind of silly, but it is what it is. If there is a real bug that is found here, Microsoft isn't gonna come to this issue list, and a developer, even a Microsoft engineer, can't say, this is a real bug in the UI, we need to fix it. It actually has to go into a different process. I get it, in my opinion, it's kind of stupid, it's big company stuff, big corporate kind of stuff and everything, stuff they gotta figure out, but it is what it is, and so we guide you and say look, if you've got an end user problem, go to tech community, that's where it should go. If you're trying to do a feature request, again, that doesn't belong here either, we're gonna send you over to user voice, that's where Microsoft triage is, potential things that you could do, right? So, or things that do submissions or changes that you can request. If we see it as a feature request, then we tag it as a feature request, it'll put a comment in the issue that says, hey, this should be done as a user voice submission, and then it closes the issue. The one in this case that was frustrating to me, that I kind of jumped on this, I made a comment of in that issue, which I told the person, hey, look, you didn't give us any context. When you created this new issue here, we have this section here about like a developer environment, and it talks all about, here are the different things that we need from you. Let me put this in preview mode, you can see a little bit better. So with your environment, it tells you first delete this before submitting, but then all this stuff, it's like, what browser are you using? What framework are you using? What's your operating system? What tooling are you using? I'm gonna show you where we're gonna make an update to this in just a minute, but it doesn't give us any context. What version of node do you have installed if you're doing SharePoint framework stuff? Without that information, there's not a whole lot that we can do with this, right? So what we did, what we're doing here, I guess, not what we did, but what we're doing with this, is what I mentioned to them in their issue, was I said, we need more context, you deleted a lot of the prompts in the section in the original post. So again, I tagged them again with context, I need context detail and attention and that was automatically added the author feedback. Again, the person responded with just a giant gulp drop and our gulp output drop and with another error here, but the main root of the question was, I mean, I had a lot of feedback for this person or a response that I had and I'm gonna go ahead and paste that in actually and just right here. So let me go ahead and paste that in. That's a typo. First, you haven't, that's what I meant. Okay, so effectively what I did here is I just said, look, you haven't given us enough context and that's why I was talking about my last reply. So that's the first thing. Second of all, I saw an issue with what they posted and thirdly, I just said you've got a lot of, there's a lot of stuff in this project and if you're not externalizing some stuff, then you're building a gigantic bundle. So I'll go ahead and drop this comment in here, trying to prompt them again and I'll do the exact same thing. I'm gonna remove attention to detail and I'm gonna say, yep, we still need feedback on this one, okay? And I know it can seem like we're being nagging, whatever, but I mean, if I keep asking, we keep asking questions, this is the way that we communicate these things to you. So let's look at it. We got any other ones here. I do have a couple other ones I wanted to highlight. 55, it was 55, we had 5589. Is that one still showing up as a triage, 59, five? No, I don't see that, so let's do it. Let's open, nope, that one's specific. I wanna come back to that in a second. Oh, here's one. So this is kind of a compliment. Command and Run, super duper fast, sweet. And as you can see, Bo says, hey, it's great, kind words, yep, sweet, okay. Everyone's kind of like saying nice stuff here, but appreciate it, but it doesn't really go in, there's nothing really to act on here. So we'll just be friendly, hey, thank you very much. That's awesome, so I'm gonna come over here. I'm just gonna close this thing, go ahead and remove the triage, and I'm just gonna go ahead and close the issue because I mean, there's really nothing to do with this. But hey, love the compliment, love good feedback. Another one here with this one, add in permissions at the list level, let's go through this. My goal when I sit down to do this is to get through to where there's nothing left on the triage. I want all of those done. All the triages should be completely done. Let's just double check and make sure a couple things here. Let me make a quick change here. It looks like I've got a problem on my stream. I can improve this a bit. Getting a little bit of a warning here about my feed. This is my frame rate's too high. Again, it's part of my newness of doing this. I have to go back and look at that because it doesn't look like my frame rate's too high, but it actually looks like I have it set to 30 frames a second but it's telling me to do that, but I have that. So my camera's not set up to be, I don't know. Anyway, okay, add in permission at the list level. Can it be done? Okay, so this one you kind of need a little more context with, but I know what this one is. I looked at it ahead of time. Someone's basically saying, can I do add-in permissions at a list level or at a web level? Add-in permissions with add-ins, they are to an entire site collection. So I'm just gonna go ahead and just comment on this. Unfortunately no, at the TLV, at the site collection. There we go. So because they're applied there, unfortunately no. So I'll go ahead and comment. And what this is, this is a question about add-ins. And it was a question that has been answered. Now what's cool about that is that now that it's been flagged as answered, is that we have the bot will kick in and it will wait, I think like three days, maybe five days. But if the answer remains, if the person didn't have any kind of a follow-up to their question and it's marked as answered, then it'll automatically close the issue. So it'll get that out of the way. But I won't see that again, which is good. So then I can go back to my issue list. Didn't mean to close that. There we go. And now you can see it's gone. So here let's go through and open some other stuff here. So this one we'll look at in just a minute. Let's look at this one. This one says getting started with Power Automate, link doesn't work. Clicked on the link, it didn't work. I was seeing it yesterday. It looks like the link is working now. So okay, everything's fixed. So this is not really, there's really nothing we can do with this. So I'm just gonna leave it as, what was it? I guess it was by design. I'll just leave it as by design. And so I'm just gonna go ahead and close that issue out. And let's see, what else we got here? How about fix for dev-office-com? What does that mean? Accessed dev-office-com up. It's a dupe of 55.97. Is that the other one that we have here? Yep, okay. So what this one did is that this issue, they're reporting a problem with a URL. And you can see here that this guy, so this is a Beau Cameron, Beau who's also on the PNP team, Beau jumped in and said, this is a duplicate issue. So what we try and do is we try and keep the issue list from getting a lot of duplicate issues of showing up. And so the way that we do that is what I'll do is that if there is an issue, we call it out as being a dupe and see how Beau put in this pound and with the number in there. What's cool about that is if you come over here and look at this issue at 55.97, when he did pound 55.97, GitHub automatically linked this issue to the other one. And notice here that when Beau did that, you can see that it added this extra entry into the list. So what's cool about this then, and I can also see that someone's already submitted a pull request to fix this. All right, cool. So I'll come back to that in a minute, but because this is a dupe, I'm gonna come over here and remove triage. And we actually have a tag for dupe. And what that will do is you'll notice that that's gonna automatically get closed by our bot. All right, so let's see, what else we got here? And property of two strings, let's just double check with that one. And this one, you know what? This person, there was absolutely, there's no context here. So I have one for this. And notice this person has created an issue, but they deleted our entire template and just put an error in this and then a picture. So I mean, my nature would say, I would shut this, I would delete this right away and delete this issue, just being like, this is completely invalid. There's absolutely nothing here we can do with this. They didn't do it from the docs. They actually did it by coming to the issue list, creating a new issue. And so they had to have deleted that template. Frankly, that's really irritating because it shows that they're not taking any time to help. So what I'm gonna do is I'm gonna come over here and I'm gonna tag it as an issue. I'm gonna put a, that's something with tooling, but I'm also gonna say something about context, right? And so that's gonna flag it back to them saying, you've given us absolutely no context and I actually have a response that I already typed up for this person. So I'm just gonna leave it as that. So there we go. So asking for context. All right, so now where are we with our issue list? We are, all right, sweet. I've done everything I normally wanna do with this. Now this last one here, this is gonna apply to a pull request. And so I'm gonna switch gears for a second and I wanna look at pull requests. So this is something else that I do on a, I try, I do this on like a weekly basis here. Wow, people have been updating the last few minutes too. Well, not a few minutes, I guess three hours. Okay. So these pull requests, this is stuff that where people have made a change and they've submitted it to the repo for someone to look at to merge their changes into the live website. These are really, and so all this stuff is really good. Now one of the things that I do is that, again, one of the things I look at is I, here we go. Look for any PRs with review changes requested and then I also close any issues that are listed as please close. So if I open this guy up, one of the things this will do is if someone has, not everybody has access to be able to close stuff, but if you have an issue and you put the hashtag please-close, then when we see that, I'll look at the issue and I can go ahead and close these things for you. So there are some people who don't have right access to the issue list, but they can tell that this thing doesn't need to be open and that's how they end up getting closed. All right, so that was one thing. But then the other thing that I do is I come over here and I look at where we had a pull request with reviews changed, the review was changes requested. So here, these are a bunch of PRs that I looked at and I asked for people to make some changes to it. So this one where it says fixed broken links and Office UI, so Office UI fabric. So let's go to this. Now look at what this guy did. So this is a beautiful pull request that was submitted. When you create a new pull request, you're gonna get this experience that you see here. And you get this template that gets put in and it's like, is it a new article or is it a content fix that you're doing? And so what, and forgive me if I mispronounce your name, but when I went in, is it fully spelled out here? Yeah, so what Nandeep did is he went in and he deleted the one that said new issue or new article and just checked off the one that says content fix. Fantastic, so I know you're fixing something. Second thing, are there any related issues? The template gives you a way to go through and to link to different issues and see where he's got pound 55.97. Well, if you go back to the issue that we were looking at before, here's where he went through and he had put the hashtag in the actual PR 55.97 and what that did is that added in a link into the issue so that now we have this nice cross-linking thing going back and forth. That's great because by seeing that, that's gonna allow us to see very easily find stuff and to fix any kind of an issue that's showing up or to be able to automatically close this. When I went through and I looked at this, I can see the commit that he did and when I went and I looked at his change and forget all this red text, this is just formatting stuff that's going on with GitHub so it's not a big deal. But if you look here, let's see if I can find my changes. All right, so see the red part is what he had submitted in his change. Oh no, sorry, the green part is what he had submitted. So notice here there's this en-us so most people can't tell what this stuff but as somebody who's worked a lot with the Microsoft documentation, I know what their rules are and what they're going to be expecting us to do. And so in this case here, I know that the developer.microsoft.com site has something that will automatically reroute to the proper localized content based on the user's HTTP request headers, the user agent. It's coming at another user agent, the local for their current browser. So I know that they do not want us to put any of the locales in the URL. So if I went to this URL right here, right to where it says, well that was the URL he had actually changed. Sorry, this is what the content was originally set up as. This is what his change was and you can see this better if I go to files changed. So left side is what the content used to be, right side is what he had changed it to. And what he had changed it to was he had actually put in the en-us right in this area and that's why when you saw in the conversation I had with him, I saw the en-us and I said, please remove the locale link. That set dynamically, blah, blah. Now, when I did that as I reviewed it, it actually said, I'm requesting you to make changes. Well, he's already come back and he's already addressed those things. He actually had it in two spots. He went in and he removed the locale from his changes right here in this comment. He fixed it. I can go and I can look at the content that he's modified so I can see up here, files changed, I'll go look at the content. Yep, sure enough, no en-us, no en-us, fantastic. So review changes, everything looks good. So I'll just say, yep, I approve it. Okay, so everything has now been approved. So there's my approval for the change I requested and now I can go in and I can merge this into master. So when I say confirm merge, now watch what happens. Notice that the open switched to merge and if I go over to that other issue that he had cross-linked, it's now closed because it shows that I went through and I just closed it because it got merged. And you can see here, actually if I refresh this, you'll see that this PR will show as merged. There, so see the PR is now as this is merged. Now what that means, what's gonna happen with this is that his changes have now been applied to the master branch the way the developer docs work. There is a live branch and then Microsoft is responsible for taking what's in master, putting it in live, which makes it go out to the public site. So you won't see these changes right now. If you're watching this live, you'll see those, these changes show up like in a little bit, okay? Okay, so now let's go back and let's look at what other PRs do we have here? So we got a couple other ones that anybody make these changes for me yet. So I'll go open up these three real range. I've seen nothing since then. So maybe just, I'm gonna close that. Same thing with this one, change requested. Nothing since I did that. So I'm just gonna close it, changes requested, nothing. Yeah, okay, so nothing I can do with those guys. So these three. So let's take a look at these. So I'm gonna go over here, let's look at these PRs. All right, well it's in this one, broken link, fixes a broken link. All right, let's take a look at that. Web parts, web dash parts. Let's go look at that doc broke. Oh, that's not there. That's gonna be over here. And we can just check this. There's different ways of checking this. I have a fast way of doing it. So we're gonna go find the section on web parts and just click into one of them. Yep, web dash parts. Let's switch guidance to this. Yep, valid link. Cool, so I'll come over here. Everything looks good. Review them, approve, submit, merge, confirm, merged. All right, sweet. Let's go look at the next one. How about, let's do mention library can be hosted from site app catalog. I jump around with these things sometimes. So for the initial article, what may think you can only do this? Tell this, check the crime changed. Let's look at it, what did he say again? So from the initial article commit content, one may think you can only render SharePoint library components from the tenant app catalog. However, I've been testing this and not correct. You can also host as close as site app catalogs, maybe useful in the sense that you have a site collection for, I'm not gonna do this one just yet. I'm gonna come back to that one because I believe that that's not supported off top of my head. I may be wrong, I'm just, I'm just flustered because we're live. I'll look at that later though. Here we go, a partial fix for this guy. All right, so I have proposed these changes because when trying to navigate, I'm trying to leverage this on an extension using Yoma and I had issues when the code solution was in. Let's just see how big of a change he's talking about. These are code changes. All right, I'm not gonna do this one right now because that's gonna, I wanna review it. I don't wanna just run through that. Let's look at this one real quick. Window Location Query, is this the one I just looked at? A better one to use the URL query. Query does query to search. I don't know about this. All right, so I'm just gonna comment on this because we don't wanna just make a change just cause someone thinks it should be changed. Like we've had some, some people will submit stuff saying, I don't like the way you did the sample. Here's a better way to do it. That requires somebody to go through and review the sample and that can take some time. So it would help if it's more than just, I think it'd be better. Let's see, so that's the list of all of them. How would I go about submitting a pull request, right? So I have one where I've actually, I've already gone through and I made some changes this morning. So I'm gonna come over here to my GitHub account where I had forked the SP DevDocs issue list. Here we go. And I have a branch which will update build issues. Okay, so what I had done is I was updating, this branch is 100 commits behind master. Wow. Okay, so now I am not, if it's 100 commits behind, there's no way I'm gonna go through and just refresh this. We'll do this in a different video at different time. But basically what I was doing in this list or in this is change. Actually, let me do this real quick. You guys aren't gonna see this as I'm not gonna, I can share my screen with this. Let me do that. So let me change this. So let me show you what I'm gonna do here. Let me get my windows set up correctly. And then I'm gonna explain what I did. So how do I, let's add another screen capture. So let's switch to VS Code, but that's not the right one. Hold on, let me get the VS Code on the right repo. So here's what I did. This morning before this, before I did, we started this live stream. I actually went in and I wanted to, I wanted to show you how to go about submitting changes to the submitting a pull request. But in order to do that, I needed to make some changes. And so do code. And so I made some changes this morning to the repo. There we go. So now you can see my code. So I made some changes to this, this morning. Let's make that look bigger so you guys can see that. Well, that might be too big. Oh boy, that's really big. To the templates, because the templates originally were having like, they were inconsistent on the context. And so what I did is I just, I added some other stuff to make things to give it a little bit more context. But clearly we've made a bunch of changes by merging pull requests in and somebody else has been making changes to the main master list. And so my stuff is now out of sync with what the repo and the main repo is. Not my fork is out of sync with theirs. If that's the case, you saw that it said that my branch was a hundred commits behind. So we're gonna fix that. And the way that you fix that is by refreshing your fork because you only wanna add stuff to the top of the branch. You don't wanna go through and add your stuff if you're way behind, okay? So here's how I'm gonna fix that. First step is I need to refresh my master branch on my local, on my laptop in my fork. So I'm gonna come over here and do a get checkout master. Okay, now, but the next thing I wanna do now, so watch my hands with this, okay? I've got stuff on my local laptop right here or right there, or actually, yeah, it's right back there. My changes, my local copy is a clone of my GitHub accounts fork of the Microsoft SP DevDocs issue list. And you saw that in the browser a second ago. So what I need to do in order to submit my update is I need my fork to be equal to what's going on in the main one. So to do that, I need to go to my laptop down here and pull everything, the latest stuff from the Microsoft repo down into my fork, push those back up to my fork in my GitHub account and then push those up to the Microsoft repo, okay? So if you just Google refresh a fork, it'll make sense. Basically, I just need to make myself current. So I'll do that by saying, and I have a remote that's already been set up, a remote, so if I do a get remote-v, I have a origin which is pointing to my GitHub account and I have an upstream remote pointing to the SharePoint DevDocs. So what I'm gonna say is I want to get pull from upstream master branch. That's gonna pull in all the stuff that I don't have in my fork from the SharePoint one. I'm gonna take that and I'm gonna push that to my origin which is what the default is. So now my master is gonna be equal to the same place. They're now equal up in GitHub. But remember, I have my changes on a separate branch. So I'm gonna check out my branch. What did I call it? Update, yeah, update build issues. So this guy now, my update build issues is behind master because we just pulled new stuff into master. I need to get my stuff. So like if this is my stuff that's on my laptop, this branch right here has a couple changes right here. The problem is though is that master has stuff above it. I should only, a really good pull request should only add stuff to the top because if it's down here, I could create a conflict and there's no way that somebody is gonna merge those in. I would never merge in the submission if someone didn't have that cleaned up because basically you're saying, hey, I made some changes. They're gonna call some conflicts but you go clean those up. No, no, no. If you're gonna contribute, you need to fully contribute. So what I'm gonna do is I'm gonna say take everything from master and push it into this branch. And the way I'm gonna do that is by saying I want to rebase my branch off the tip of master. So take my stuff and put it onto the top. Get rebase off master. There, so now I did that. So now if I do a get log and let's just do, I'll just do one line to keep things clean. I can see get master. Okay, you can't see it here. I can see Nendeep did some stuff. There you go. There's Nendeep's thing right there as well. Fix broken links. Okay, so I've got my changes, get log. So we can see the changes that other people had done and then that's old. Okay, so now I should be able to say get push. Now what this is gonna do is this is gonna push my changes back up to, back up to my fork. All right, cool. Now let's go back to our browser. All right. And you should be able to see that. Nope, it just switched it back. Go back to browser. Cool. Now I'm gonna refresh. Much better. This branch is even with master. Actually, why aren't my changes ahead of it? Well, that's now frustrating because I made some changes this morning. Man, I'm gonna lose my stuff. It appears I've lost my changes. Oh, well, at least you get to see. So I'll go back and I will fix that. You know what? We'll just fix it right now, ladies and gents. Let's go back to our changes, configure. Let's go back and switch back over to VS Code. Close this up. What changes was I making? We had, I had under the feature requests. Nope, we didn't wanna do anything with feature requests. Close that out. Custom. Environment details. This is where I was making the request here. So environment details. I wanted to ask not only your operating system, I also wanted to get, we also wanted to ask for, I know none of this stuff should have a space in front of it. It is target, target environment. And that is, for example, SharePoint Server 2016, SharePoint Server 2019, SharePoints online. Just leave it like that. A couple of things I remember I changed before as well. I wanted to make all of these show up as ores. So we'll just do space or. And then I also wanted these to be bolded at the beginning. Just to kind of clean it up a bit. So stars, stars. There we go. Environment, environment details, I just do that. So target environment. So what we'll do is I will copy all of this and from custom. I want that exact, I want it to mirror what is in the bug request. Really don't understand why I lost my stuff. It doesn't matter, we're fixing it, but so we wanted that feature requested matter. And I think issue template was the base one that we had. Yep. And we will save our changes like that. Sweet. So here we go. Issue template. All right. So fix up. Let's see. Update issue templates for. Consistency added target environment as guidance. Might be misspelled. And. Duped. Across all issues for. All right. So I will save my changes. Sweet. And we will push those up. Oh, you know what I did? I think I already know what I did. I think I picked the wrong branch. Make sure it did. All right. So let's go back to our demo back to our browser. So let me switch over to browser. I know exactly what I did. I am on the wrong branch. Fix up issue templates. One commit ahead five behind. Okay. That's what I did wrong. So you guys are not going to see this. I'm going to do this really fast. So anyway, I may change this morning when I just said refresh the, refresh the branch and it said I was a hundred things behind. Yeah, that screwed up. There was no way that that was the case. I should have, that should have been, I should have caught that. I was only like four or five behind. And which I basically refreshed the wrong branch. That's why I didn't see my changes. My changes were already there. So if I come over here, you can't see this but I'm just going to jump back and forth. I need to say get check out fix up issue templates. Get rebase off master. Get push. All right. So what you're going to see, there we go. So that's the one fix up template. This is the one I want to look at. So I'm going to go to this, this branch. I'm one commit ahead. And if I look at the list of commits, I look at the list of commits, fix up. Here's the one that I had too fast. Here's the one that I had updated this morning or I added this morning. Right. And then there's the detail added additional prompt for target environment and all that stuff. All right, cool. Here's how you go through and you submit a pull request. You can do it one of two ways. You can do it from your branch and your repo or you can go to the main one. Like here, this is the main SP dev docs. And I want to go through and I can say go through and compare and create a pull request. Now let's see the best way of doing this. Make sure you can actually spell. So here, these are the comments from my commit. So I'm going to cut those out and I'm going to put them down here. We have a section down here that says what's in the pull request? These two things are in the pull request. I can get rid of the guidance section here because it even says at the very bottom you can delete this paragraph after reading it. Come back up here to the top. What kind of a category is this? This is a, it's not really a content fix but that's kind of where it goes. Delete this line, I will do that. Delete this paragraph and you're done, got it. Related issues, there are no related issues but I'm not going to delete this. I'm just going to say this is not applicable and then I will create the pull request. What this is doing is it's going to modify the templates that people when they create a new issue. So that now I'll go ahead and merge this in. Come on. So what's going on here is that you can't merge, there's a build process that's going on with the share with the all docs.microsoft.com. Everything's going to build and if there's ever an error during the build then it'll flag this as being a bad build. So right now this is, I can't merge this until this completes, okay? So let me jump over here. I see some people have left a couple comments so why don't I see if I can go find those comments. To me, I'm jumping over here on another browser. Oh, you can see, so let me go, come on. Facebook's taking a second to render here. Come on Facebook. Oh, no comments, just some comments and stuff but yeah, cool. Looks like some stuff might happen with our Facebook video. Oh, look at that. I did screw it up with YouTube. Apparently you have to click go live. Well, I just totally screwed up the entire stream. Bad gummit. Oh, well, this is what it is. Here we go, but check it out. Our update over here, it shows, ta-da, we can merge the pull request. I will say merge pull request and I will confirm the merge. Ta-da, all the changes have been done. So now if I come over here to our issues list and if I create a new issue and if I say I got a bug report, we now have a new thing in the template that will prompt people to say Oh, come on. Because we were getting this as a thing, target environment, SharePoint 2016, 2019, SharePoint Online. Ta-da, cool. So it looks like I screwed up my YouTube stream because it looks like nobody was watching it because I never clicked the go live. I didn't know you had to do that. I thought that the app I was using would automatically do that. That's dumb. But anyway, just, I'm a newbie. I didn't do it, my bad. All right, that's everything that I wanted to cover today. I guess I don't really have too much of a call to action. I'm curious what you thought about the live stream. Again, like I said, I've never really, I've never really done this before. So we're not, not really done this before, but I've really, I haven't done this before. But today, so what were we doing today? The whole thing that I was doing today that I wanted to focus on was all about kind of taking you behind the scenes and what it looks like to triage poor requests and issues with the SP deb docs issue list. Hope that gave you a little bit of insight into how this works. And I hope you might have learned something. And so with that, thank you very much for taking the time to watch this today. And I will, if you got any questions or something, if you got any questions related to this, please feel free to comment on this video either on the YouTube channel or on Facebook. Might have to go back to that YouTube stream and delete it and upload the video that after I download it from Facebook. So just, I was a bit of an idiot. But yeah, I guess with that, I got nothing left. So with that, I will leave everybody to their days and we'll see everybody next time we do this. Thanks a lot.