 Last week we actually managed to make the merge request for the floating panels feature But as you all know, it doesn't actually end there We also need to support Let's say it like that the merge request actually addressing all the feedback until it's completely done and accepted by the other developers as well and it's actually a pretty important point So the first thing I want to talk about is here in GitLab you have this very nice feature of Being actually able to reply with emojis to merge requests So you can actually see what's kind of how many people like it how many people don't and in this case I do have six likes and one dislike. So I think it's fairly good It's a bit sad that I do have one dislike which actually means that there's one person that doesn't quite approve it as is which is like I Would prefer if it wasn't For all patches, I think we should try to strive for complete consensus But sometimes you can't quite achieve that Now regarding the feedbacks, there are many of them and they're pretty good Like I gotta say I was actually impressed by how specific they were and in this case They even use the built-in feature of GitLab of suggestions, which means let's take this this first one as an example so this is Suggestion to add read-only to these properties like this and then also use triple equals and Double quotes for floating This part of the patch makes sense as far as it goes for like a single quote instead of double quotes I don't know the difference and I don't quite care for the triple equal It's like indeed in JavaScript. It makes sense. It's like Check that this is actually equal without covering for the type without You know actually transferring anything from one type to another The read-only property I gotta say is the first time I see it in QML So let's actually go see what it does QML read-only property It's always nice to learn something new even though at the end I already know that I will probably accept accept this as is because I mean It look this person looks like he knows what it is doing. So So read-only properties must be assigned a value on Initialization after a read-only property is initialized It is no longer possible to give it a value Therefore imperative could or otherwise Which makes sense. I mean, it's not like I would like to change the floating or screen covered You know variables Hopefully it still updates to actually when these or these variable changes But I'm pretty sure it they do it does if this change has been suggested. So I'll just apply this suggestion and I guess I can just click this and That's it and Then there's probably a commit button somewhere Let's see the next one Can floating panel SVG be loaded when needed put it in a loader? That's a good question. I don't think so, but who knows Okay, so what is a loader Okay, so the loader QML object is able to Dynamically load a subtree from my URL or a component. So to use it I do need to make a component which I do know how it is But I'm not really sure if this is the right place to do this So what I'll do is investigate a bit like asking around and let you know But for now, let's switch to the next one, which is this one. What does this do? Well, it changes all equals to have one more equal and I also forgot accidentally some spaces That's good. I can just add that suggestion and Switch to the next one in here again Equals become three equals and that's always good to have so I can just click on add suggestion here again, I have read-only properties and We've seen before that that makes sense. So I'll have that and This is the end of the list. So we can just click on a place suggestions and I think this commit message is pretty let's say add read-only Properties and switch to equals equals equals And that's it the important stuff from this MR is gone and then of course when you do merge requests like this, you also get some discussion and In this case, I won't really go through all of it because it's not that interesting and The idea is is this a feature that should be set by The plasma theme or by the user my personal opinion as it's pretty clear if you read the merge request This should be set by the plasma theme. However, there are other people rightfully asking me to make it customizable by the user and Also another request is to make it customizable per panel So in my mind, it would be either all floating panels or none I've been asked to make it. Maybe one panel is floating. Maybe one isn't But of course, we need to ask ourselves. Is this worth it? How much code should I add in order to support that feature and Let's actually give it a look In here, we have the file with all of the C++ of the panel view Except this is the header file, which means that it's just commenced with documentation and function declarations and Cuma properties declarations. As you can see, there's not actual code But we can see all of the properties for all of the functions. It's pretty useful It's particularly useful to show you this line here, which is panel view opacity mode opacity mode So what's that? So opacity mode is Declared here can be adaptive opaque and translucent and if you know what I work on you probably guess that this is Whether a panel chooses to have this adaptive opaque or translucent thingy going on or not And the point is right now, there is no property whatsoever That says if a panel actually wants to be floating or not Because that was until now defined by the plasmatheme. If we do want the panel all panels to be Like maybe floating but maybe not We would need a new boolean, I guess property which says whether a panel floats or not And we should also communicate that choice To the QML stuff by creating a Q property It's nothing too hard to do. We just need a new property Function to read it a function to write it This thingy a signal for when it's changed It's mostly boilerplate code. So it's probably fine But then but then but then we also need to add a button in the panel settings to actually set it And how do we do that? Well, let's pick up the code for the panel settings And here we are This is if you want to go for it in plasmand desktop desktop package contents configuration panel configuration So what happens in here very simply put we have a series of Heading I mean the heading Which says now is panel alignment and then we have a column of buttons With inside of it tool buttons, which are like center bottom Or right and then there is visibility Always visible how to hide and so on and these are tool buttons tool buttons And we can see that here we can we say that it's checkable. So when you press it it stays done It is checked if the config dialog visibility mode is one aka if it's set on how to hide And when it's clicked you actually set with just one equal the config dialog visibility mode to be one aka outright So it wouldn't be too hard to actually implement new buttons However, my only like complaint which would be hopefully temporary is that these more settings pop up would become even taller it would get It would get actually underneath my video as it is probably already And I think it's already pretty big as is So we would probably have to split it in two columns However, I am indeed planning on working on a redesign of the edit panel dialogue entirely Hopefully before like, I don't know February March February so Yeah, but it would totally ship in the next version and I'm not a big fan honestly However, it's also true that those buttons would only show up If you have a theme that does support floating buttons So the the question now here is is it worth it because it's a bit of extra code It's a bit of extra options in the panel settings, which I'm not a big fan of too many options are indeed a problem however Well, I've been asked to and it is true that for a Macintosh like the latest Macintosh setup You do need a floating bottom panel, but a non floating top panel So it is a use case that I understand But again, it's all a question of is it worth it? And I don't know I let other people decide and as far as I've managed to see in the merge request up until now It seems like Other people says that I should so I will put in the extra effort that I've just described which is not too much and That should be about it So it's almost there. I need to change these things and you've also seen the nice feature of actually being able to apply suggestions and when you do that It's always A good idea to actually sync up your local changes to the one in git lab Where you actually applied the suggestions right now suggestions are applied on the web, but not on your computer So you go into the right repository, which is totally plasmid sstop, right? Is it plasmid sstop? What is this plasmid sstop? Yes git branch git checkout What is the name of the floating panel? this one and then we git pull Maybe origin no Just git pull Is that it? That isn't it, right? git pull origin and then work nicola floating panel that should do the trick We're saying okay git pull from origin, which is git lab Work nicola floating panel. This is the branch is the one i'm working on And it rightfully says 20 line has been modified in panel dot qml because the suggestions if you go count them were 20 lines So that was about it And more catty stuff will come in the following days at this point. I'm doing videos pretty much daily And I don't know what else That was pretty much it It's a bit late, so yeah