 Okay, we're live, or we're not live. We're recording. We're recording. Right. Thanks, Victor. Let me just share my screen real quick. Hopefully the temperamental part is past. So you should be seeing the merger grass page of 1500 lines. Just to give you a little status update over the past couple of days and weeks or so I've been working with Mario to split up the work regarding the front and in the back end. And let me just go real quick to this part. Right, so here, if you guys want to follow along the evolution of what's done and what's not done, that's exactly the status right now. As we identify things like optimization of low level stuff and tests, we're going to keep adding here so that we have the full visibility of the front end part. So the ones that are checked are supposedly features that are working and working well enough to be checked. But some of them still need to be implemented. So this we're we're waiting on back end that we got last night that we can now implement. And a few other things just hasn't been addressed. So right now this is an E installation. I always have this thing just that I remember that I'm on E in. Yeah, so basically, it looks all the same with a batch comments enabled, as if it didn't have it. But once we press the commenting thing, that's the only difference we'll see is the buttons are different instead of having just want to comment that will have those two buttons. So as soon as we start casting, you will allow just move this out of the way. I'm already happy, Andre. I don't think you need to demo anything else. So once we start a review, the bar will pop up at the bottom, right, just submit the review with the count. And as we add more, another test, add to review, or we can add comment right now. Right. That comment is just basically a regular comment. It doesn't go into the review. And we click here. Then we add another draft. We add to the review that count will come up. That count will come up and that count will come up. Could you add a comment to one of the discussion threads. Exactly. So that's, that's those were going to be my next stage. Inside a discussion, we already have this checkbox to resolve a discussion. Right now, this is kind of like a dead thing, because that's exactly what I'm working on right now. So that the, because we didn't have the backend support as well. So we just got it yesterday. And the point is the discussion, sorry, the draft will store whether or not to change the status of the discussion. So if you write this, so I have, I'm not even checking if the discussion is resolved or not. But if you did this, then when you write to the review, it would show here on the pending right. That's another thing that I haven't gotten to work yet, which is displaying the, the discussion, the draft on the thread because we just got support for that last night as well. But ideally in front of the pending here would show will resolve a discussion. Right. That's the, the proposal for the by the UX for Pedro. I can show you one thing that I prepared for you guys to see how it's displaying right now. So Pedro, we might need to tweak it a little bit because right now this is the draft. So let me just select it. So this is the draft. Right. The one on the top comment that was there before, so we don't have a lot of visual distinction. And I don't think we had that specified on the mockups. So like after this is properly just displaying, I can send you the link and you can play around and you can tell me how we like to show this in particular. Yeah, good point. Yeah. Okay, just make another that and then we can talk later on that. The other thing that we haven't done yet is the actions of the draft that is also on the to do lists. Here, I believe. Not yet. Right. Maybe we need to do that too. Because as far as I know, we are supposed to allow editing the drafts, right? Yeah, editing it. The leading should be supported. Exactly. So actions to draft. So this is how I'm doing things that I don't forget anything going forward. Great. So apart from that, the pending part is basically just saying that it's pending. And then when you click here, you should be that is also part of the part that we just got yesterday to publish the review. And you'll be able to just from any of these buttons, you'll be able to publish the whole thing right away. The next feature that we have planned for after this will have the preview popping up and everything. But right now, this is pretty much the status of things as it is. One thing that I wanted to highlight though is that so far, none of the batch comments manifest themselves on the on the discussion tab, right? So the drafts are only present on the changes as well as the bar. So Pedro, I don't know if you're if that is exactly how you intended. But one thing we did try to do is like the this bar kind of like keeps aligned to the center when the collapse bars are done, just to make sure that they're always in tune. Yeah. So the idea would be to make it available. So when creating a discussion from a code line, so it's what you were showing just now. So you always have to navigate to the changes tab to add a comment on a line of code. So that's exactly what we were aiming for. And also, when replying to a discussion, which was what you were showing right now. Okay, and that could happen from either the changes tab, or from the discussion tab. Okay. So do you think you'll be worth displaying the bar also when they are in discussions. So basically all the time. All the time. All right. Yes, yes. Because I mean you could be like moving around between like tabs looking at one thing looking at another. And I think it's important to note that you still have these comments to publish, even though for some reason you went to the other tab. That you have lost the comments or that they, I don't know, people could freak out for some reason and then they have to go to the changes. Yeah, that's why I brought it up as well. Right now it's implemented this way just because it's in the diffs. Yeah, Mario. I'll go to the discussions, by the way. Like you already support the diff replies and the regular discussion replies. So that should just work. Yeah, it's a matter of the front end. So basically what we did is I added that to the diffs app. And this is a different app. It's the notes app. So I just have to find that shared component thing that just shares everything but the story is already shared between the two. So it's fine. So the making that effort. Yeah. The only place where it wouldn't be available right now because we still haven't implemented the new designs for. So basically in the future we want to get to read. If you go all the way to the bottom on this screen. Like we want to get rid of the comments and then you have to click to open that drop up where you choose if you want to comment or start a discussion. In the future we want to get rid of this and there is already like issues UX ready issues to do this. So it's just a matter of time before we get rid of that and essentially you will just post comments and then reply to comments. So you, you don't have to think beforehand if it's going to be a discussion or a comment. But so this is just to say that for batch commenting or reviews or whatever you want to call it. The only place where we are not going to have that functionality is when you are doing a comment here. So in this form. This is the only place it's going to be going to feel inconsistent. But it's the only place where we're not going to support it because we might as well like do it all in one go. So you're finally leaving it as it is. Yes. Okay. Yes. All right. I'll keep that in mind. Apart from that comments feedback. So this is basically the status right now and we have basically now. Also one of the things I wanted to highlight is that there's a lot of work that we have to do to split this feature onto EE because so far the merger cost refactor was done on CE. So everything on this code base is based on CE. So we're basing this not only on EE but also with a license check. So we're going a little bit of out of our way to make sure that the conflict will be as low as possible. So we're trying to make a good separation between the code between CE and EE, which adds a little bit of an over complexity on the front end part in terms of organizing code. So we're trying to make sure that it's still because of his experience on the web ID is very useful. And I might pull him in to help me out at the end of the like of the stretch to get to get the tests in order and that sort of thing. But just to raise visibility that the fact that it's a split feature between CE and EE adds a little bit of unseen work that it's not on the UI. I'm hoping for comments and feedback and ideas and anything you guys want to say right now. If you can scroll back, Andre, to just one of your examples there. I forgot the latest designs and probably this looks new to me. So I'm sure Pedro added some more awesome designs, but I was curious about the result discussion piece. I forgot how that worked. So this is basically what we see right now on the on that form, right? Depending. It will display discussion stage results or if discussion will be resolved, depending on this. That hasn't been implemented yet. No, no, no, that's what I'm working on exactly now. Okay, cool. Yeah, even this screenshot is a bit of a lie. Sorry, Pedro, because it's not in a discussion, right? This is just a solo. Yeah, exactly. This would happen if it's in a thread, although that will rock it. We can read to it. Thank you. One thing though, you have a smiley here. Are we supposed to be able to put smileys on drafts? No, no. Yeah, it's just the edit and delete. It's a good point. All right, that's fine. So you were saying that it's a lie. No, but just to, so one thing that we have today, which is kind of, I don't know if it's, I think it's just for simplicity is when you start discussion in a line of code or something. I think you can immediately say if it's going to be resolved or not. Maybe I'm, maybe I know what you mean. Let me just have a look real quick. That's common and resolved, right? Are you talking about that? Yes, yes. Can you, can you already do that from a new comment? No, you can't. Okay, I'm trying it now. You can't, it's only when replying. Yeah, yeah. Okay. Okay. So you were absolutely correct. It's, it's kind of a lie. Yep. Yeah. But we'll take that into consideration though. And then the other, the other side of it. So there are actually four states, I think, which is in that little notes, which is discussion stays resolved. It was, if it was already resolved and the user clicks the checkbox, so they don't affect their resolvability of the discussion. So stairs resolved. There's also the other, which is discussion. It's not resolved and it starts, it will be resolved when you post the draft. Yeah. So you have four states, discussion stays resolved, will be resolved, discussion stays unresolved or will be unresolved. So, yeah. Yeah. We already discussed that with Mario. That's why he was nodding yes, because we, we covered those cases as well because the point is the interface will then translate that to what I sent to the, to the backend, whether we want to change it to the state or not. We have that sorted, but as soon as you have that, of course, we're going to go through you and make sure that it's working. Okay, cool. Yeah. So we might tweak a little bit of the copy because we don't have the copy for all of those, but we'll just throw something in and we'll check with you. Exactly. Do the next demo. Yeah. That's, that's the best approach. And the next time I already know that you're awesome and you've already thought about that. Good. Yeah. So in terms of plan of getting this work out the door, as you probably aware, it's not going to be ready for the 22nd. However, I am pushing as much as possible out of my way to focus on this. We just got help from, from my team to help with the hiring so that I can like focus more on this. And we hope that over the next couple of days, this will evolve in the direction that we all want. And by next week, I hope that we can start with the reviews and tests that, that we will need to get this merged. So, yeah, that's it. More comments. Victor, I think, I think you wouldn't say something. Just, I think you, did you already demo the case where you add comment now to an existing pending comment? I think you did, right? No. So the point that we discussed at the time is that when you have a draft, you, that's the last of the thread. You can add, you can't add multiple drafts to a discussion. So as soon as I am here, so I think I have one here because I had to prepare it manually for, for you guys to see. Where is it? Oh no, it's on the changes that one second. It doesn't really make sense because you can edit a draft. It doesn't really make sense to have multiple drafts to the same discussion. Right, right, right. You can basically, and but it, but it also prevents you from adding a comment now. If you've added a draft. Right. You would have to send that comment. Yeah. So you would have to, which is, yeah, which is totally fine. Yeah. I mean that's like a really crazy weird. That's really weird. I mean, I'm not, I'm not sure what you're going to do with that. Why would you do that? Right. So you should just delete your comment or change it to a, a comment now scenario. So. Yeah, it's not, it's something that in the future we can tackle, but for, for now, for simplicity, I don't think we should do it. Like it's, it's just a bad feature. Like it's encouraging weird behavior. Leave it. It was against it. All right. All right. Yeah. Like I think that this is, and then I like the pending thing. You know, I think you're not, you're not allowed to talk to me because you're not going to talk to me or anything like that, even if you're not going to talk to me because you're not going to talk to me because you're not, you're not going to do that. Right. But what we can do, or associated with the discussion. Or I guess this is associated with the comment, right? Yeah. That was what Andrea was, was mentioning that. And it's very well mentioned is that. The mock-up that you have in the issue. It's like a very nice state. Because it's a yeah, it's the Happy path. now as a discussion it's not clear exactly oh what what is pending where does my comment start it's kind of it blurs everything okay so yeah i have to review the the pink yeah i think the pink the pink is a good choice yeah no i like pending because we argued when hazel when i argue we discussed a lot about the word draft yeah um and which was uber confusing so i like how we're not using the word draft anywhere here which is good well i'm not gonna come over we're fine fine with that but yeah the word draft is already the word draft is already used right so i don't i'll let you work through those use cases or those detailed cases but yeah there's yeah exactly draft save on the the browser draft yeah and then but now we're not calling we're calling these pending comments and then we're calling the entire object a review review and then you're calling submitting it um or discarding it so i think that's nice that we have that demarcation of terminology so there's no there's no confusion like what yeah i think you got better with that iteration that Pedro uh yeah i like that i like cool is the is the the thank you is the discard review working no nae we got the published service yesterday uh on the back end and i will work on that over the next few days uh as soon as i have this thing i can i can send you things and if you want um there's nothing stopping you from checking out this branch and trying it out um but right now it's a little bit broken here and there but i'll keep you posted on the channel as i as i add more things yeah if you want yeah when when when you think it's in a good place for me to review just let me know so it depends on what's coming my way over the next couple of days but i do expect that by next monday uh and we're going to be together on tuesday uh in braga so right and tomorrow tomorrow yeah also tomorrow you don't know that but we will be at the same co-working space okay that's fine so yeah so we can do we can do that together but regardless of that i'll try to keep you updated as i add things to the to the things so if you want to test it out feel free and send feedback in our way what we really don't want is to get surprised at the end so now is a good time to if you're missing anything like we just did like i didn't i didn't add a point here of course we wanted to know we knew we were gonna have this but it's good to know that we don't have the the smiley thing uh it simplifies and we have yeah i mean i don't think it makes sense to add smiles to your own comments yeah yeah i mean some people do that but some people are weird i mean yeah even even your drafts not your own drafts like my i don't actually not your drafts um that's that's the that's what led us to stop people from upvoting their own uh merge requests or comments or whatever and we just reverted that so people are weird man well yeah i would argue if it's more work to leave it out then we leave it in but i don't i'm not going to be a strong advocate either way we do want to support quick actions right we we need to make sure that we end up supporting quick actions on the draft notes as well so that you can just assign it to somebody else as part of the review process uh but but then it would be it would be processed when it's submitted right for reals that's right right it would be processed when they're submitted okay so one thing i wanted to check on that mario is i don't think they're working right now uh yeah right now i am passing i am passing it through the note creation pipeline so everything but i didn't test that quick actions actually work so that's i just want to make sure that we add it to the description so that we don't forget to test that path as well yeah because i remember there's there's an issue that someone opened i think it was remi i think he opened an issue because the quick actions are not working on the changes tab and he believed that he used to do that back in a day uh i've never done it i don't remember exactly if this was there before the refactor but as you can see here it doesn't say that the quick actions is supported if you go to the discussion reviews are supported on the discussion path as well so you can send uh you will be able to send draft notes in the discussion tab if there's already a comment if there's already a discussion you'll be able to do a draft reply to that discussion yeah so that's where quick actions could work all right we'll have a look and my point is if it's broken right now i think we'll have to fix it somewhere else not on this mario quest yeah yeah yeah so if it's broken out then we cannot add it to the changes tab but we should like it right now it should work on the discussion tab yeah so after you add after you add it to the discussion tab uh we should remember to to make sure that at least it works that it works there at least right so i i i checked the ui is not great but you can definitely use quick actions on like mario said when you're when you're doing code review essentially which is which is weird though right like mario you you argued that you want to sign somebody but um were you seeing like an actual code review like you're talking online comment or are you talking about just like regular commenting uh like non-line comment discussion right if you are doing a code review then when you're done you want you're probably going to want to sign it back and because we have quick actions you don't think well maybe i can just add it to my last draft that's that's a fair use of it yeah yeah well i mean yeah that that's that's a really weird one that that's like almost a new use right because you would expect you could you could for now like if it's like really hard to support we can ask the user to some click submit review and then you type in another box yeah if it's if it's broken in the changes tab then yeah we should do it we should fix it later but either way because there's additional crazy use cases where you have like 10 quick actions and i don't even know if that would work they contradict themselves yeah contradicts fine because we we always have contradictions and then the backhand i assume we'll just just throw up but then can the backhand even handle like 10 of them and like sort of like series shortcuts whatever like you have workflow now essentially so like yeah we can handle it multiples uh like in series right because you're i assume you're just posting the common one by one to the database and then you're processing the quick actions one by one um then we've just invented like a feature that yeah so on that on that let me just say this thing that right now they don't have the quick actions on the changes on the diffs comments and when we have the preview from my mistake and Pedro's idea was when we show the preview and you publish i think there's a chance to have a text area there that we can add a comment to publish as the finalized review thing so there it would make a lot of sense but right now on this merge request on the situation we'll definitely look at supporting quick actions on the discussion comments not on the diffs everyone agrees i just want to make sure that we remember that use case because it is going through the no creation pipeline already so we should get it mostly for free yeah i saw that on the code that i'm using as well for the for the because i'm reusing a bit of the code of the note so it's there i just haven't like they all get deep into it but i'll definitely look at that in the discussion stuff cool yeah and i'm looking at the i'm looking at the current like production it doesn't say comments applied when you do it in a code review set like a line thing so hopefully we won't get like 10 commands applied like bars for you so that yeah like when you do it here yeah in the new in a new comment there it doesn't work if you're replying to an existing discussion it works oh oh is that right oh okay i didn't even know that but yeah i just didn't see that commands applied thing so i just checked it right now but whatever yeah there's probably a lot more crazy so the only reason so we're not going to support this because it's broken and someone else is fixing it is that it i don't think it's broken i don't think it's broken i don't think it's well i've never seen explicitly used um but mario maybe you have but i haven't seen um quick actions used in like attached to a line review a line line comment i mean yeah i i actually do not really did not have a use case for uh quick actions in the changes tab until now but we have a review because as part of the review you might want to change exactly no i totally agree it's it's like a new it's like a new thing i totally agree yeah yeah this is identified it's on the create side and it will be handled there so whatever we do there will affect of course the batch comments by then once we yeah but right now it's not not not working right okay well no i think just autocomplete it's broken right it says that being said about quick questions i was doing is oh sorry sorry sorry he says that it's incomplete the label but i think what it's actually with what he says um yeah it still adds i'm just looking at the description it's still currently still adds a label so the back end still works it's just the autocomplete ah all right right yeah right right okay we'll definitely look into it um and keep you guys posted anything else before we move to the to the other point yeah i have a question um is it possible for multiple people to add a code review on the same read request so these are personalized is individualized per user so you'll only see your drafts so you can have your drafts other people would have their drafts and they will publish whenever is that the question so yeah if two people are posting a code review at the same time and they both hit submit review both of them will show up there's a chance for conflict there so what we've been thinking about right now is uh to just publish anyways so if you're replying to a discussion for example and you think that you're going to be uh the reply right after the other person but somebody else hits publish first or just comments in that discussion first then um and then there's that uh edge case right like what do you do do you just add the reply anyways under the new comment that showed up or do you error out and have the user fix that but uh for the initial at least we're thinking well just publish it anyways and then the user can delete or whatever they want to do and then because then it would need more um more ui work right uh to handle those error cases where you have to say hey this change do you still want to publish it catch it okay cool yeah i would say i would say all that is still it's still consistent with what we're doing right now it's just like it's a difference in degree it's just made worse because you can save like 10 draft comments but like for example right now you can open a page and you can add a comment to a discussion that was like just deleted five seconds ago and then maybe like it didn't your browser didn't refresh in time and you hit submit and like something happens i don't know what happens but that's made like infinitely worse because you have like five comments instead of one comment so there's no from that perspective it's the same error yeah although that question also just reminded me that i need to make sure that we handle the case where two people start a draft for the same line in a file because i think we can only have one discussion there so that will be a conflict so i need to handle that right but even from a back end perspective wouldn't that be almost like you get that for free in terms of like that already happens today right yeah i mean like yeah that's what i was saying like that already that can happen today right now yeah it can happen today i just don't know if we do it for free or if we would okay error out or what so i i'm just making a note to remember to check sure anything that's currently only two separate discussions would be created on the side i mean two separate discussion ids okay right so then you would have like essentially you have inconsistent back end data from that perspective right well no there will be just two separate discussions on same related to same same row yeah but well i mean from the front end that can't that shouldn't happen right like how do you display that on the front end are you think you're talking about two threads on the same line yeah i think it is possible it won't it won't cause like the thing to break it might cause semi-consistent spacing um oh okay that's really weird okay but but we'll double check yeah i just i just wanted i'm just making a note to check because if if it just adds two discussions and front end can show that then it's tiny annoyance not and but if it's easy to fix them yeah better fix it now sounds good um okay thank you for a demo we went a lot longer than than i thought we would yeah i need to run because i have an interview interview in five minutes but anything else on the plan on the gender uh no i i have a quick point and then rami has a point so uh but you know uh and you just just jump whenever you need to yeah i will um so thank you so much under awesome yes definitely um so i just wanted to to show uh this board for 11.5 and then i started putting things into here and here and then i didn't put any do 20 second here because it gets annoying um so we need to invent better boards to support it but um all this to say that i don't want to like have too much transaction so this is especially relevant for andre and whenever shan gets back so yan and mario can relate this to shan but obviously we'll repeat it over and over again but i don't want to have to say like oh like oh 11.5 is ready please schedule it like i want it just to be ready all the time so so andre and and back and in front end can always look at 11.5 and 11.6 and 11.7 and have an idea of what what's important um and so so i will do my job to keep this up to date um and other people can can participate as well i'm trying to use the ordering in particular um so that's why i think i found a bug and i want to fix it um but the idea here is that i think there's a reasonable number of issues um and then when you do scheduling andre and and and back end then we'll move stuff to a future iteration but then i want this line here to be visible by you so you can always look at it and so i never have to tell you that i'm done um prioritizing issues it should always just be prioritized um so hopefully that that'll be useful um obviously i'll still like you know give you a kind reminder gentle reminder that oh like uh because like what what i do need is we have to lock in the scope like by the seventh or something because there's the kickoff and all that right so so that i i definitely do need so if anything that's more transactional as a request from me to you folks but um i i don't want you to need to ask me what's what's next and 11.5 and 11.6 so 11.5 is already here 11.6 and 11.7 and 11.8 and then after 11.8 we don't have 11.9 because we have 12.0 so that has been already been decided by yoke and mark and other people um it doesn't really affect us in any huge way but just just good to know and so if you look at 11.5 planned issues there's around 40 issues and then 11.6 is around like 30 maybe and then and then just decreasing and on purpose and that's not going to scale very well because i just keep pushing things out and then there's issues get created faster than we can schedule them so we'll figure something else out but right now there's like a long tail of issues that are just getting less and less with each milestone um but i've been encouraging people like especially on this call to just like if you have stuff that you care about just like um you know mentioned and say like i really want to work on this i think we should do it i'm going to put into 11.5 you know just kindly uh mention me and then i'll probably leave it in or if i think i own there's really no room or we should do something else i'll just you know reply back and say like oh i moved it to 11.7 or something like that so please continue to you know shove stuff in but i'll constantly try to not let it like we had like 50 or 60 issues inside 11.5 um sometimes last week and there's like no way we can do all that and then i moved them out into the later milestones to make it more realistic uh no questions comments ramiya you're up next yep so um this is just a suggestion i i just wanted to understand like uh if this is doable so um in the process of writing test automation um at least for the api uh changes like uh can we have the api definitions given a bit in advance uh before the development starts uh maybe what i would mean is like if we are targeting a 20 second cutoff date maybe by 10 if we can have at least the api definitions or the interfaces frozen that would be good so that even the test automation code could be written in parallel and by 20 second all that okay i'm just theoretically putting it but we just need to try it out and see if this really works so at the end when the development completes it should be as simple as running it through the test code and seeing if it works so that's what we actually want to do but i just want to understand like yeah i understand there might be few changes while developing it maybe a few changes are which can be accommodated is okay but at least if 90 percent of whatever design or the interface is decided well in advance it would be a good thing so what do you think like i just wanted to understand your thoughts on that as well maria i think that would be beneficial because it would force some initial planning of the api but also the 10th is just three days after uh we officially start the next milestone so basically saying well sit down and plan all your 20 second which i mean we definitely try it at least once right yes so 10th is just a random date that i came up with but uh somewhere a bit in advance so that we have time to write the automation code is what i actually meant so yeah i think that two things one it's a very good idea because it will force us to plan way ahead and think carefully about the things and we do that already on the back end of the front end as well because we get the back end to do mock end points for us to start working on the front end and there's no reason why we can relay that to you as well so i think it makes sense and we should do that for the next time yeah good point anything with backing on front end we'll have to sit down together and actually because usually endpoints change because back end doesn't isn't 100 aware of what front end can send or or needs to receive so that just means front loading a little bit of work but that sounds good right so so is this like pretty much the same this would benefit both front and end and testing because if you're doing api testing right so essentially it's it can be piggyback off of that existing process right yeah so what kind of yeah so i just want to understand if there is any swagger doc or something that is created or shared how do you share the mox uh no uh when when he met mox uh we just basically add the endpoints to a controller and then have him return something just so that just so that he can get uh HTTP codes back okay so are we having plans to have docker dockson i mean swagger dockson place that would be actually better right okay so these are few thoughts that i had maybe yeah i think i mean we can definitely think about it because yeah it would be a lot easier to to do the mocking with a swagger doc is just we need to make sure that everybody's on the same uh yeah right on the same level with uh how to write them yeah right yeah and one more question maybe this with basic uh does the plan team own merge requests as well i was just curious to understand like no so it's super confusing because we we just talked 40 minutes on a merge request feature uh we we used to um plan team used to be called discussion team and discussion team used to do uh issues and merge requests and amongst other things and then merge requests but never did code never did like commits and branches and stuff like that and so so i i guess in the past and made somebody decided probably my boss decided um that that we wanted to do that because issues and merge requests look very similar in terms of like you know sidebar all those features but then it's also very dissimilar once you get to the hardcore code review features exactly like this one and then how it becomes related to branching and merge strategies and all that stuff that so it we just said that it made more sense that we live with the dissonance of the page looking different and like yes there's a lot of overlap between like merge request commenting and issue commenting sidebar there's a lot of overlap there but what you gain in in that overlap is that now the the create team which does merge request is very consistent from like a code review perspective or a developer workflow perspective and i think that's probably more important anyways um so this particular feature it's been around we've been working it for a while and so that um now i regret it but we said that like oh we'll finish it as a plan being not regretted um but of course we'll try it's and we committed to it so that's why we're working on that's why it's appearing in plan mario's in the back end plan team uh uh and and andre is the engineering manager for both the create team and the plan team on the front end and he's also working on the feature right now so that's why it's uh it turns out well for him because he's gonna have to support it long term anyways because he's still the create for an end man i don't know if he's doing that long term or we're hiring another person but anyway so that's why it's not not as bad for him but mario will have to you know finish us up and lose his baby to to a great team member um but that that's the idea there okay yep thank you and then yeah so i think i think we also promised that we would have the two follow-up iterations in which i also now regret which is what mario was mentioning about that there's like uh if you the submit review button that you were seeing in the demo like we have a design when you click on it and then you can see like a summary of everything um or like a table of contents and then the follow-up after that is on the experience in the email notification side which is to combine all the comments into one comment or one one email notification so that is not insignificant work and that is like i mean like right now we're quote-unquote getting from my perspective it's like andre's working on it that's fine you know you know from a front-end perspective andre's like he's mostly managing anyway so then like i don't really count him as a front-end person in terms of team member so oh okay he's doing it for free and like other front-end plans being worked you know like oh mario's working on this oh if only mario can do plan things that'll be great so so it's like but then the the the combining the the comments into a thing will definitely be back and so i anticipate there's a lot of work there so i'm scared about that but we'll work through that um mario do you know if that's do you think that's a lot of work just since we're on the topic just combining comments i know every time i ask a developer that question they always say no it's it's easy but if you could give a you see all the on the top but you gotta deal with a few edge cases there just make sure everything is yeah no it's just add it's just adding a lot of flags to make sure that each note creation doesn't create the notification then you'd create them all at the end right okay so so the strategy is you delay then okay and then you batch it out there okay that sounds hopefully it won't be terrible so it won't be easy but it won't be hard right i'm gonna push really hard that we do the smallest thing so we'll we'll we'll fight that out in a couple of iterations with Pedro um and then and then i'm sure i'm pretty sure this will be a really really popular feature so i am excited about it as you know as a collab it's an awesome feature yeah so it will make like it is it is way overdo so people have been like like flaming us for not having it um but those same people make this look good right the plan yeah but those same people like love us afterward when we have it so it's i don't mind and so for something like this like we're we're not the first but we're not the last either there's a lot of code review tools out there that are just really just doing code review and nothing else that um that have had this feature forever github has it but they're not just code review they do a lot of other things as well um but but some other tools might i don't think all tools have this right now um but definitely we're behind on like since we're talking about code review like for code review like really awesome code review tools where like there's these like fabricator other tools where they they're like essentially a plugin to github right so those companies or tools are just innovating on just code review and they're growing really fast so we're definitely behind them um i know create teams at james ramsey product manager they're working on this like super awesome blog post to tell the future of code review in good lab or i guess just develop a workflow so i'm really looking forward to to what they tell us about there but that's way beyond there um about the the what we were talking yesterday uh it was more related to the portfolio management but i think it affects everyone in the plan group as well of the resources and things like that don't you like after we deliver the the first iteration of batch comments do you still want to go through and do the rest of it are we that no this should be this should be create team they should they should um so we should do whatever we're doing this mr right and then we should do the two follow-up features the the drop down or drop down and then the the email notifications yeah yeah and of course we have to you know be a good stewards of github and just create all the issues and but but like all that should be transferred over to the create team from like uh both implementation and prioritization standpoint right definitely from an engineering standpoint but you know like you know product and design often are a little more flexible in how they participate in the rest of your lab right but but so you still want to do the following the the fall to follow that that's the ball that that's the current plan i i like i want to renege on my commitment but i don't think that that's really fair but that those two issues are plan issues right now so that that's a commitment before um so i mean that that that's that's all i can say like is it not i'm not i'm not i'm not i think i'm not actively asking that we we push it out so i'm almost like you know like let's just get this out and then maybe we can second put the create team and see you see what they say of course i think of course they would love you know free development from of course yeah so but i think it's like we should probably just get this out and have a conversation with them and say like oh what do you think um why don't why don't we give it to you and then you guys run with it um but you know um i haven't thought about that deeply yet yeah i'm yeah i'm just i'm just thinking of ways to help us have more time for us well everybody can contribute Pedro including bringing up this discussion in the relevant places so you know just send a message to to the product teams and the designers and engineers no and then that's that's why i'm bringing it up at least here at first to understand if it's still open to discussion i think so why everything again that's open to discussion i i i i haven't actively brought it up yet but i think it's still up for discussion so okay so yeah let's let's wait until this is merged and then i mean uh we cannot wait for this to get merged because the the other two are scheduled for 11-5 and i know the the scope is not closed yet but um yeah we can we can talk about it right now yeah yeah maybe we should start massaging this idea with yeah yeah yeah yeah let's let's have the conversation we can we can just descend on the create channel and then say like oh we're getting really close would you like to pick it up and so but and we could show it like oh it's awesome it's really good yeah but we have other things to do as well yeah we have even more awesome things to do it's more awesome for them um but yeah no no thanks for bringing up that page i think i think it's a valid point um given given how long this this particular show has taken now it's like way beyond like if ramya is coming in asking like why are we doing this and then we like it's like it's weird for her it's like oh that's probably a signal that we should have transitioned this a lot longer ago and to have andre doing it right as an engineering manager like he's going into code and doing this demo oh yeah well yeah and he's the manager of two areas so he's like having so much responsibility on his shoulders that i don't think it's fair yep um yeah i mean he can complain on his own i'm not complaining on his behalf but i'm just saying that uh i agree i don't think that's the way it's supposed to work cool thank you no no yeah yeah let's let's bring it up um all right thank you pager i will anything if nothing else three minutes no nothing okay so i'll put this on youtube uh going one two three okay yep i'll do that and i will see everybody next time i know