 Okay, cool. All right, so I had started some notes for today's meeting. I think I had an open question on the, the, the project branch, and then a couple of questions on a question, a bookkeeping question on an older branch, and then a question on the what I think is the milestone two branch. And I didn't put another question like I'll put it in here now though, let's take the easy questions first I think, which is milestone five can be merged to the master branch. Question mark, so it's it's there it's passing. Those are my questions what questions do other people have that they want on the agenda before we start working through the agenda. That it. The question that I have is how is interactive testing and like code reviews going right so let's put that one on the list so interactive testing and let's put a new one on code review and feedback to harsh. Good. All right. Okay, so let's the interactive testing I just attempted to download today and I apologize harsh that I'm so far behind. But when I tried to download today so let's take interactive testing first. I can't get a build of what I think is the correct pull request is this the correct pull request. Am I looking at the wrong one. So when I look at this one on ci dot Jenkins that IO, it's failing to build. And then when I tried to build it locally it's also failing to build. I don't think it was failing when I tested it. Yeah, so here's the here's the message that it reports on ci Jenkins IO it says, where is it compilation failures, bunch of complaints about static imports. And the same thing happens on both here let's, let's present it an easier to read format this one so this one will show us now here. And what we see is it saying, Hey, there's a package reference a reference to package that has not generated in its path. Okay, so I understand what's happening. Like I deleted. Yeah, like I deleted some like hook models which were there originally, and it was involved actually in the tests so the tests are not compiling that's the issue that you're facing right now. So like you can directly create the API file and start testing the tests are not the problem it's the production code right. Ah, okay so what you're saying is, is if I do a build that skips tests entirely. Like Maven HPI HPI colon in between. You say oh so you're saying if I do HPI colon run. No Maven HPI colon HPI that should like create a HPI file for you for testing the plug in. Ah, okay. All right, let's see. Great. Okay. Okay, this is new. No, that's just me making mistakes I would suspect. Alright, so let's try it like simply Maven HPI colon HPI that's what I did and it was working for me fine. Interesting. Okay, so. Okay, so you are getting some index dot jelly. Okay, I didn't mess up with any jelly well maybe maybe I'm in the wrong branch just a minute let's let's do this all the way. Are you okay with me doing this while we're here together. Yeah, sorry. Okay, so what I'm going to do is I'm not working. I'm going to delete that branch to get branch of minus D milestone to list the pull requests. So I think the one I want to build is 1553 correct. Yeah. Okay so let's check out that pull request, and I'm not going to merge the master branch to it just take it exactly as it is. So just to minus D skip tests install. I think that will do the same kind of thing won't it where it attempts to compile and create. Oh no, that didn't work. Okay, so. API colon HP I. Oh good okay there we go. Alright, so that gives me I have no idea why why I was okay. So now I've got that able to be used. So I can install that onto my test system and get working. Good. All right so. Seeing like they're all about tests that's not the production code. So, so the, the fact that see I is failing I should I can ignore that for now because the production code can be tested, even without having tests or that are able to compile. Like the thing I messed up one thing like when I deleted the model from the hooks. I think I missed checking the jelly files or those other UI files maybe I don't think UI files had any correspondence to the like models but I'll still check maybe I'm missing something I don't know I never got this error. Interesting. Well so so the, the dot generated thing that I saw. Was commonly from, from, from what is it from IntelliJ or other places that I've seen those kind of things arrive. Yeah. But, but no need. Yeah, I think if, if, if you try to build the commit before I deleted the like useless imports and the hook model. I think that would be perfectly working because those were corresponding to the test like I, I didn't do it test after deleting the models because I was pretty sure that nothing should be breaking. I completely did a maven like maven build and it was working the way I wanted to. I didn't have any problems. Okay, so if I, if I check out your two commits before. Two commits before okay so. Yeah, I think that's what I think this and that will show patching get so it says patching tests. And now if I do the maven. That should be a yeah that I think it should be working now. Let's see. Okay, so still, still complaining is it okay if I just leave that to you, because you've given me on the test. No, no, no, wait, wait, wait, wait, wait. It's actually different. This time it's complaining only about the action resolver test. Previously it was complaining about other tests also. Okay, it was complaining about the other test because of the models that I change now I get what's what's getting wrong. And it's not that big of a problem like you'll have I'll have to pass that test with the correct models that that I should be using not the builder generated models that are generated using the like the pojo builder that's that's what's happening so it's part of my stone three. Okay, all right, so this is this is handling this is already on your list you're comfortable with it. Okay. Just check the production code like just create the API file and deploy it and deploy it in your Jenkins instance and if it's working then it's great. Perfect right and that's that I've already got so I can just I can just do that right now I think I can even do the. Let's see how would I do. Let's do it live are you okay if I just deploy it live. It will take time. Well, let me start to deploy and off we go. So home mark wait. I just want to be sure that no surprises while I've got you here. Okay, so currently, if it doesn't work then like we can go to commit for three commits before, and those commits are only about test they're not about the production code. Perfect. That's something like crazy goes then. Oh, it was it lab dash plug in dot. HPI. See if it'll take that. Oh, no, it won't. Okay, sorry, I'll do that later. We can we I don't need to slow us down with that. All right, good. I think you've answered my questions on interactive testing it is what I need to do is build the plug in with maven HPI with MVN HPI colon HPI ignore any other and failure to compile tests. Right, did I get that correct. The test compilation. Like, if it gives you failure, it's not a problem. If the build give you a failure like the normal production code build gives you failure that's a problem, and it will not give you a failure. Okay, good. All right. Okay, so I think I've got the answer on interactive testing to have milestone to then. And we've got the list here of suggestions from last week's meeting. Are there any of these that you want to revise or change saying oh no don't worry about that one worry about this one instead. I did some like things also, but I still think you should be testing all of them, like even if I tested some of the part of it, but still I think you should be testing all of them. It is not that big of a deal and mostly you should be testing the intersection of these tools, like pick any two or three of them and try to implement them at the same time and see if the plugin is working the way it should be. Good. All right, very good. Okay, now this one we had a link to a parameter configuration got it. Okay. Yeah, but that's linked for all those things in documentation that's there. Good. Okay. All right, so the question interactive tests. I think we're we're set then I understand the goal the objective the ideas. I will start on it today. Let's go back to some other questions that I've got. Yeah. So on the GSOC 2023 project branch, it's got the milestone one work. Yes, victory. It's behind the master branch is there is it okay if I merge the master branch into it. Not yet I would say like because it's just partial changes right if I would say like you can merge it after the milestone for like it's perfected enough. Like if they like skipping the milestone three even if the milestone, not even skipping like battle will be angry, why it's not tested. So yeah, like, still the milestone for is complete I think you should not work with master branch. No, no, I'm not saying merge to the master branch. I'm talking about merging the master branch into GSOC 2023, the other direction. Yeah, you can do that but like, I'll have to. I think there might be some breaking genius. Yeah, yeah, that's that's what I was thinking like, I think some pull requests got merged into the master branch which I'll have to see and try to like fix my pull request that I make so maybe you should wait a bit until all Okay, so do not major changes yet. Because other changes arrived on the master branch. Okay, great. All right, thanks. So risk. So they're conflicting or it's not the word is probably not conflicting but there are master branch changes need review by harsh. So you'll take. Actually, let's put it this way changes can be there. Like that's why I'm thinking about it. So how about if we just said harsh review the changes on the master branch. When it's convenient. Yeah. And merge the master branch, because you know, you know which things are safe and which aren't. Like, I have to like retest things a bit to see if they're working perfectly or not. I'll most I'll most probably do it after the milestone for gets more than that. That's a long way like first get some get the milestone to then get the milestone for my parallely working on the milestone say that's a long way. Okay. So we're going to say we don't merge into the project branch. So there's currently some automation running and the automation will fail the merge right now with a fail merge with a conflict and that's okay we accept that. And then harsh you'll you'll resolve that conflict. When it's convenient for you there's no rush on that. Is that okay is the way I've described it. Yeah, because like, when we live more into the master into the master branch then it will go to the production right. Again, this, this is not me talking about merge to the master branch this is merging from master to our project branch so definitely we are merging anything to the master branch, absolutely not right that's that's still that's we've got an awful lot to do right interactive testing all milestone to three etc but but getting behind the master branch is dangerous that that was my word is is when you've got one of these long long running branches like gsoc 2023 project. The master branch is our destination and if we don't keep up with it. Maybe we can get lost in conflict, it's going to get, it's going to get very messy after something. So Chris I assume you're okay with that approach then that we will. We will wait. I'll wait for harsh to do the, the merge from the master branch into gsoc 2023 project branch, rather than trying to do it myself. Yeah, thanks. Okay. Good. Alright. That one's yours. Great. All right. Then I had a question on milestone five milestone five looks to me like it could be applied directly to the master branch. Yeah, but like, I think reviewed yet and Chris also wanted to add some documentation changes to it. Okay. All right so needs further review. And so, yeah. So still the preference Chris from you the preference is to merge this to the project branch, rather than going all the way to the master branch. Yep. Yeah, project. Okay. All right so reference is to merge to the to the project branch. After detailed review. Good. Okay, maybe you can recommend some things to add in the documentation because like, I don't know, like I added very basic stuff regarding traversing the plugin. I added stuff mostly which I felt I felt it was difficult when I was starting to contribute to the plugin, mostly about the Jenkins code understanding. And I hope that if any contributor is trying to contribute then he will be able to like understand the code base I am hoping if if you guys want then I can even explain the code base but I think it will make it a lot longer. It's already I think 150 200 lines. I don't know. Yeah, my sense was it's a good description. It's I like the depth that you did I'm very impressed with the depth that you did thanks very much for spending the effort to do it. So, so, but I didn't feel like when in my initial review and I didn't feel like oh we need to ask for even more. I think you've given a good description. You've given up a great starting point like a heck start to anyone who's trying to contribute. Great. So I think we've addressed my question on milestone five. There's this milestone to pull request. That's a draft that has conflicting files. Is there a reason to leave this open could I just close it. Yeah. So okay if we close it it's been replaced by number 1553. So you're okay if I just go ahead and close it harsh. Yep. Great. All right. Okay. Great. All right and we talked through this one for me which was. Okay, failures are tests. Our only tests build with maven HPI colon HPI to. I wanted to add something because like if you want to build from MVM HPI HPI before you do so you have to. It would be a bad good idea to do the target directory first and then one MVM and then skip tasks. So Chris you're saying do a get clean then a maven install skip tasks. So it's like the MVM and install and then dash the skip tasks first otherwise otherwise we'll complain. Okay, like that. Like I can explain why he's saying this if you want. Please go ahead. So like what's happening is when when when you actually try to maven verify or maven install it tries to get the target files and the target files that it's trying to get can can create a conflict when it's trying to create another build using maven HPI HPI. It's kind of conflicting if the commits are changed or if you're trying to like do things again and again and if files retain themselves then they create conflict. That's why you don't want the target files, because when you run the build it the target files get created again. So yeah, that's why you want. Okay, and this is due to the use of generated objects by that maven is doing object generation maven maven is doing source basically Java code generation. You know, like it's the pojo builders like that. The builders that are created for that. The problem is like the older plugin use that and the new plugin is completely off of that. But I, I have to patch up. I think I have to see a bit on that. Why why that could be a potential problem, but yeah, Chris pointed out things right. I see. Okay, so, so the, the odd, the surprising build pattern or build command is likely due to the transition from old. Let's see rest easy to new get lab for Jay. Is that correct because due to pojo builder. Did I say that correctly. If you're directly if you're completely removing your get lab plugin from your system completely and then like using the, the build that of the milestone tool, then it should be fine but if you have some artifacts of the previous plugin, and then you are trying to use the newer plugin then it will create conflicts. Okay, all right. So, so this get clean is is a very good thing as Chris said delete the target directory. Got it. Okay, thank you. All right, so we've discussed milestone to and the testing I've got upcoming. Anything else on that one before we talk proxy settings code, or is there anything we need to discuss on proxy settings code. For the milestone for like I created the draft PR and I did some Docker based testing for that like for the testing, I use the engine X. But like I faced some problems, I tested a lot of it and I skipped some things like I slowed my testing just to see that milestone to is having some problems. And I'll have to change milestone for also right. So I was just slowed down, but regarding the milestone for proxy setting draft PR that I've made. I added the instruction for you to test also in the like contribution contributors md file that like the documentation like milestone five pull request that has all the instructions you need to have. I can use engine X, but there's a problem with engine X engine X all actually so I have to explain like that. So you say that's in the contributing md file. Yeah, great. The milestone five pull request that I created that's excellent. Okay, so I can refer to that for suggestions and exploring. Now, my intent is to focus on milestone to first and not worry about milestone for in the in the short because there are so many things to test on milestone to is that okay or do you want me to to look at somehow look at them in parallel with each other. Like, actually, if the milestone to code looks good like it, if it's manageable like there is no major problem in the design of the milestone to code that I did. Then you can actually test all those things that I mentioned in the milestone to and also the milestone for simultaneously by just testing the milestone for because of course the milestone to has. The milestone for has all the changes that are in the milestone to as well as the milestone for proxy settings. So that would be a more complete test of the plugin, like if you are testing the milestone for plug in with everything that I just said, then you are actually testing the complete migrated plugin. Yeah, so but given my inexperience with proxy configuration. I was hesitant to add to attempt to do milestone for without doing milestone to first so yeah okay so so what I'm going to say is milestone to tests to test completed and confirmed working. Good. Okay. The problem that I faced with engine x was I was using engine x proxy server and engine x proxy manager for managing them, like I was. So the issue that that was happening was when I was creating the proxy host and I was creating the access list for adding the authorization credentials. I was not able to like my browser was not showing me the like authorization thing, which I think is happening for some people and it's not happening for some people. I thought there was misconfiguration on my side, but when I searched through the engine x like GitHub repositories, I found out an issue that states this problem. So I think there is something like wrong with engine x proxy manager it seems like so maybe if you want to test you can use also use Apache web servers or any other thing like you want for testing the proxy servers it should be fine, like I tested the on the unauthenticated proxy servers completely it's working the way it should be. I tested with a wrong password and wrong username and all and it was giving me a full of the forbidden. So I think that was also like working fine. I was not able to test the working like a password and authentication like the username and password. So yeah that is the problem. Let me capture that so incorrect username and password and saw expected results. Yeah, but the working username and password is not giving like it's not granting me access inside the like, and that's the problem it's not giving me photo three it's just not granting with the access to that get to enter the username and password, the correct username and password. That's the problem. I just it but what happens is my doctor container just crashes for some reason and it's database is lost, and then I have to restart my doctor container, and then once I restart my doctor container all my credentials which I made in the engine x proxy manager goes away, but I don't know what's happening. Okay, so container crashes with, and this is the engine x container. Yeah, with correct username and password. Good. So there's, there's, there may be some your, your, your, your guests seem sensible to me that there's probably some issue in that container, but engine x is certainly not the only proxy so as you said, I could test with when I get to that point I could test with the apache apache is a proxy I could go looking for other proxies. I assume a proxy is a usable usable case so good. Alright, likely a bug, an engine x bug, or a configure, not a problem in the get plug get lab plugin. Good. Okay. Anything else we need to discuss on that code. Well, I think that's this is, this is the things which happened this week. All right. So last item on my agenda was mentor checklist review and we've got two things there one I'm out of office, two weeks from today. Chris said he was willing to host the meeting Chris is that still okay for you. Okay, and then August 28 begins the let's look at the checklist just to be sure we've got everything on it. August 21 through 28 is the final week of coding phase. So final submission everything done should be done by August 28 so we're at 20 a little over 21 21 days we got three weeks remaining right. August 21 begins final week of coding. August 28 begins the evaluation week. Evals are due by September 4. Chris does that that work okay for you in terms of, I'm available during that week and we'll get the review done on time. I assume that you're okay with that as well. Yeah, I'm but I'm, I'm not sure I guess I think the product, the co product should be due like around that time to you. Right, right I think is I assume it's I assume the final final submission from harsh which is probably then is that likely a blog post, or a some other summary the blog post is has been the easiest in the past. Yeah. So, August, let's show you put it this way August 28 blog post due from harsh summarizing results. And then we use that harsh as your as the final submission pack is final submission to final submission to Google. Like for the end term presentation I also created the slides. Oh right right exactly and we don't have a final presentation or do we have a final presentation date I assume it's sometime in September. Yeah, but no date yet. Like John Mark said it's in mid of September or something. Yeah so I'll have to check my academic calendar to see like, there is no exams and stuff in between. Yeah, well and do any of these collide with your academic calendar is worth checking. Yeah, I don't know why always my academic calendar collides with everything that I do. Because because you're doing the first and most important thing getting an education. No, no shame there that's that's good. Dr stern the PhD can tell you all about what it means to spend eight years and getting an education that's Isn't that how many years you spent Chris getting your PhD or was it only six or seven. I was like four to five to get my PhD but I didn't and masters so like before then and that took like about two years. I'm only quite with four years so it's like it's more like 10 years. Yeah, so okay so harsh 10 years of education me. I've only got a I've only got a bachelor's so I spent four years and it was already four years that I was was really hard for me and and Chris has done 10 so Chris is a doctor a doctor it is an amazing thing is very very impressive. He took a degree in physics as a computer science and it took him 10 years. I don't remember Chris your PhD is in physics isn't it. Yep. Yeah, so yes. My God. It's fun working with smart people it really is it's a little intimidating sometimes but it's really fun. Okay, yeah like we have physics department in my Institute and I'm pretty scared with those guys who study physics like dangerous people. Astrophysics is yes. All right, anything else we need to review today. This happened in the week in the state. All right, we'll meet again next Friday. Talk to you then recording will be available probably within the next eight or 10 hours. Okay. Thanks everyone.