 All right, welcome. This is GitLab plug-in modernization. It's the 28th of July So harsh if I remember right that means we've got about two or three weeks left, right? No, no, is it four weeks left because it's early September three weeks. Okay, good great All right so topics I had on main list progress so far and status on interactive testing excuse by missing last week for For family vacation, but I had a great time Yeah, you had a great time and we also had a great time actually But yeah, there's a lot of interactive testing that we'll have to do and like this week I was kind of busy with shifting of my room. So like the only thing which I did was I was working on the test I'm still not able to get the milestone two tests working like I'm not able to get the design working because Due to the GitLab 4j design I had to implement I had to reimplement the execute Method in the GitLab plug-in which is which has made the testing pretty difficult Like I'm trying to think for a solution to test it for I think three four days. I'm not able to get What to do about it? So yeah, I tried a lot of things, but none of them work properly Other other than that I wrote the track the test for proxy settings That's the milestone two locally and like the plug-in is working without it I have not really tested it with the docker thing. Yeah, like the docker image yet. I'll be testing it afterwards. But yeah, that's what I did this week So so you say that you've got automated test An automated test for proxy settings, I didn't remember that we had any of those previous No, no, no, not the automated test like the actual GitLab plug-in with the proxy setting enabled Like I wrote the code for the proxy setting not the automated tests I see. Okay. All right. So wrote the code for proxy settings. Okay, the production code for proxy settings. Yeah, got it. Okay, very good And the plug-in is working without the proxy settings code Not yet tested with the docker image needs more interactive tests. Is that right? Yeah, yeah I just I just wrote the code just to see that Introducing the proxy settings is is it's making the plug-in work fine Like the plug-in is not giving me some random errors if I enable proxy settings and it's not giving me it's working fine So I'll see like the interactive testing and I think I I have one test for proxy setting enabled like the do-check connection with proxy setting on is there in the GitLab plug-in Only one test I think Oh good. Okay I mean for me proxy Automated testing of proxies is extremely difficult There are so many different ways proxies can be configured so many different ways they can misbehave So so I think this one is one we have to agree. I I think it's perfectly reasonable for us to agree Interactive testing is the thing. Okay a lot of interactive testing is required like A lot like you can see the list that I've created It's it's it's just what came to my mind. All the other things can also exist. So yeah a lot of testing Good. All right. So and where is that list? Is that in the pull request? Uh, no, it's down like in the action items like 20 Oh, good. All right in the earlier action items. Perfect. Okay. So that's that's these tests right here Yeah Good. Okay. Very good. All right. I'm just going to steal those and copy them Up here so that I'm reminded great Perfect. Okay. Oh, yes. Okay. I see it great So this is Very good. Okay And now can I do this? Does google allow me to change one list in a list? It did how nice It kind of looked small the list is this is quite huge to be honest like There is also going to be intersection between them like using wild cards with using the fish With using the enabled advanced settings of push events. So there are a lot of mismatches also a lot of permutations and combinations of these are going to be tested. So yeah Right well at least a week of interactive testing and and we knew that that was coming right? We knew that this was This was one of the things that this project when when you originally defined it and when we worked with basal to get it Worked out. It was interactive testing is a crucial part of this thing Specifically because of how complicated proxy is so yeah, that's great that we we had acknowledged that And and we do the best we can to get as much of the testing done as we can and then Then there comes a time when we ship the code Yeah production but like I was doing the interactive testing of the milestone two and I found a problem in the milestone one like Okay, and and guess what you found something that another person didn't have to find So for me, that's a big win, right? Okay. Great a problem in milestone one detected by us is much better than somebody else detecting it Yeah Very good. Okay. So extensive interactive testing. I hope to spend some time on it this weekend Uh, the is there a specific branch that I should be working or is it the primary branch currently? Like the milestone two work in progress branch that the draft we are that I made that branch Good. Okay. So if I grab Let's let's be sure that I can see it so that I I'm doing the right thing so Here if we look at the pull requests Milestone to migrating webhook. This is the one That you're ready for for additional testing on Yeah, this is the interactive testing one Great. All right. Hi, Chris. Hi guys Okay, so for the pull request the milestone two pull requests So chris we were just going through Going through items for today harsh was noting the lots of progress last week but big bunch of interactive testing needed and We copied forward the the ideas from last week of things that need to be done Okay harsh continue anything else that you want to highlight there Yeah, so the major blocker Right now are the tests like Due to the design of the lap for the the tests are some real blocker I'm I'm still not able to find a way To to test the webhook actions that I need to test and it's a problem Like it it is in a such a bad situation Like before the execution of the action starts I need to Test that the action that it is executing is the right one And those actions are created inside the methods of GitLab or j So it is pretty difficult to get there like I tried to capture the argument And I also tried some other stuff, but it is not working the way I wanted to So in this case Go ahead Yeah, the other tests of these like the milestone to the patching of the like patching of the JSON to the events are already completed So I also like I pushed those changes like all those trivial test changes are done The tests which are not working right now are like I'm not able to figure out why they're not working So they are proper blockers like Okay, and in terms of value to you I assume it's more useful to you if I do interactive testing rather than if I try to work on this The automated testing question because of the single much more useful. Okay, great. All right, so agree that Good. Thanks. Okay that way that way I know where to where to spend my energy So that I give you the best benefit Okay Anything else you wanted to go over with this harsh? I think Because it's fine like the problem which I was having with my stone one as I have I've always almost fixed Fixed the secret token problem like in the code. I'll be pushing it after changing it. So yeah Good. Okay. So because the milestone one pull request Is is it has not yet merged to your primary branch either right this one is still open I think basal has not yet reviewed it. I think I pinged him on my stone one as well as on my stone two But he has not reviewed Okay, yeah, and no problem there that's This one I suspect he'll want to see that the tests are either disabled or passing They were I think he accepted the milestone one. We didn't have to have passing tests Yeah, I was going to disable it. Yeah Like the like Chris was doing the like doing the code review So like he was going to complete the code review till Sunday. So I was going to disable it after that Oh, good. Okay. Great. All right And like basal has not yet really seen the milestone two code at all like he has three stages of Like code review, right? So at least I want the first stage to be completed on the second milestones pull request All right, so code review milestone two is still pending Good. All right Dangerous actually because if he presents any better solution then I have to reimplement it Which I don't think so we have time for we left because it's only one month left Well, and and I think that's okay, right? If if we've done the best we can with what we've got We've certainly already milestone one is a significant improvement and and so I think we just keep going forward I'm not I'm not overly worried about that It's actually quite difficult to present a better solution because get left for j to be honest forces us to use a solution that I've used Hoping for a better solution, of course, but yeah Well, but but one of the arguments for this project was we want to be consistent with the other implementations by using gitlab 4j And so it's predictable that the other the other plugins are using gitlab 4j Probably in the same way you're using it because that's the way it wants to be used, right? Yeah It has force good, okay Chris any topics that you wanted to bring or any concerns Okay Harsh anything else then that we need to discuss here So interactive testing seems like the big thing And you're continued exploring to see if you can figure out what to do with regard to test automation and then code review of milestone two and ultimately we want to merge of milestone one To the primary primary project branch, right? The project is going quite slow because like a lot of work is pending Mm-hmm I I don't think that's For a project of this complexity. I don't think that's Objectionable. There are hard things that you're doing. You're doing major rewrite, right? While trying to preserve functionality And and those two things are sort of in exact opposition to each other, right? We would love to drop functionality if we do major rewrite or not do major rewrite, but you're doing both Yeah, kind of I don't think anything else happened like two weeks For yeah, this is what happened. This is where we are mm-hmm Anything else that needs help here? Accept tests. I don't think so. I'll be requiring any other help. The tests are the main block of the automated test Okay, good. So automated tests the biggest challenge Development challenge and then interactive tests Yeah And interactive tests Are the biggest project challenge If those two are done later for this complete Nothing much. Say that again If those two are done the project is almost complete because like the we don't have much Proxy setting tests to be adapted and the process setting has to be like tested interactively only and the fifth milestone will be about the documentation I've already written almost all the documentation that I'll be making the PR about So like yeah, the project is complete if both of these things both of these blockers are completed Very good. And and so on the on that documentation Were those things that I added as help entries of any use at all? Yeah, I think so they should be useful. Good. Okay. All right very good Any schooling things that we need to worry about any upcoming exams or other Vacation time off because we're let's see project schedule. Let me do a quick check Actually, let's like my semesters have started But I don't think it should be that big of a problem like Yeah, like I'm I'm I just I just entered my second year. So yeah, it has started Okay, so you're already in the new semester Yeah Okay. All right. So we've got September 5 is the next Is that right? We've got oh, here we go timeline Final evaluations. Okay. Final week of standard coding phase is August 28. So we're four weeks Four weeks from end from the final from end of coding And then we do a final evaluations in the last week and results are announced on September 5 Good. Okay. So we've got four weeks left and that's all Okay Like we have four weeks out of six weeks. It's not bad Well, but four weeks is not a lot of time to do as you said if if we had to do some major If you had to do some major rewrite, it probably won't fit in four weeks Yeah, that's that's the biggest fear that I have that battle will introduce something extra but yeah Go reviews Great. All right And oh and I have to forewarned I am august 14 through 18 mark is out of office Uh another vacation week Chris, would you be willing to cover for me at the meeting on the 18th or the 19th? Whatever the day of the month is So yeah Okay Thank you Welcome All right. So we've got we've got work ahead of us anything else harsh Oh, like I would say like I think Chris should be helping me with the test I think he's more capable to help me with tests right now because like he knows it more And I think mark you should be really like interactively testing it because you actually get some good testing notes that I see that that you uploaded actually on the drive Yeah, I think we should be distributing our work because like it's a lot of things Great. All right. Well and and one that I haven't done much experience I don't have much experience with it would help me learn Is are you okay if I put some a special focus on proxies? Like I'm not really um push the proxy changes because like oh, okay So there's nothing to test there. So just test interactively in general great. All right. Yeah I cannot really push it because like the I cannot mix the milestone four and the milestone one like Basil will be angry Correctly. So right. Let's keep it. Let's keep things partition It won't help that much for me to there's there's plenty for me to test without looking at proxies. Yeah Great. All right Chris you okay with that as well then Anything else harsh Okay, then let's Call it a session for day today. I'll upload the recording in Um 24 hours or less so that you've got a you got it available