 Here we go. All right, welcome, everyone. It's Jenkins documentation office hours. Today is the 18th of October, 19th of October, India Standard Time. And remind everyone, we abide by the Jenkins Code of Conduct. So it'll be nice to each other. Let's see. I haven't seen Kristen. So topics I had on the agenda, Adopt a Plugin, Tutorial and Blog Post for Dheeraj and me. Then I've got a topic on Plugin Docs Migration that a Hacktoberfest contributor has launched. And we'll talk briefly. Then Meg had a question about security chapter. She had a conversation with Daniel Beck. And I'd like to capture what she learned from that conversation. And then source structure standards for Jenkins.io with Meg and then classifying wiki pages for migration. Any other topics we should put on the list? Nothing from my side. OK, all right. So Adopt a Plugin, the Tutorial and Blog Post. So the first recorded session with Dheeraj and Pope went well. The second session starts in less than 24 hours. And the third session, likely 48 hours after that. I just like to say that Dheeraj's sections and the things that the two of you do were really good a few months ago. And they keep getting better and better and better. I'm just astounded. It's a lot of fun working with Dheeraj. He really is very, very good. Cloudy should have him do a class for other bees about how to do videos. Yeah, he truly is exceptional. But he's exceptional because he practices so hard and makes and pays such careful attention. So yeah, he thought about it. Exactly. All right, Meg, I think we may have lost you sound wise. So let's take a look at. About this for a long. So, Meg, you just came back for audio. Oh, I'm sorry. Oh, no, that's fine. OK, we can hear you. So could you say again what you'd said you'd mentioned? You'd said how well Dheeraj and Pope did and then you the audio stopped. Oh, I said that Dheeraj. Exactly on point. Dheeraj should do videos. I mean, there's I'm noticing how few people know how to make it so you can read what's on their screen when they're talking. Oh, right, right. Yeah, we have a lot of we have a lot of videos that are basically I know how to do this and I'm going to prove it to you. Yes, God help you if you want to ever try to do it yourself. But exactly. All the things. But he's learned. I mean, I know he's you know, he's been doing good videos for a long time and he's continually learned things. We could bundle those up. Right. Anyhow, I'll shut up. Dheeraj needs to go to bed. OK, so in terms of the so the the way the first recorded session work, it covers the first three three of the first four topics in the in the contributing to open source workshop notes. We'll probably cover another three or four, maybe five in the next session and then maybe three or four more with discussion in the third session. And then the idea is each of those chunks of a session will embed the video into that page. The page will describe how to do it and the person can watch the video to get a live demonstration of how to do it. And I'm pleased to note we had our first person, Mads Jacobson, actually offered to adopt a plug in based on having taken the steps in the workshop. Whoa, so so big win. Now, we've confirmed that and so the skeleton of the submission for Jenkins that I always on on my branch and we've confirmed that Dheeraj can also push to that branch. So so that's that's a big win as well. So what we see here is if we scan down a little bit. Where is it? We have to go. Oh, yes, here we go. So here's Dheeraj making a change and making another. And and here we are with me interspersed all on this branch. So he and I can contribute together. I had originally dreamt that we would have it ready within a few days. My time is not going to allow that. I'll feel very lucky if we get it done before the end of October. Dheeraj, are you critically dependent on this as part of your Hacktoberfest contributions or will you be OK if we if we're not able to get this finished before end of October? Oh, well, I was thinking about finishing it before October. Now I do think that it's a little bit difficult, so it's OK. OK, so you're that's not going to derail or damage your ability to complete Hacktoberfest. Oh, well, I think anyway, I'll not be able to do it due to office work, so it's totally fine. Oh, right. Of course, you've got a full time job now. That's of course, yes, that makes sense. OK, good. No problem. All right, so I'll be happy to review any PRs that could help. Well, and Meg, you are welcome to let's see, how could I? Yeah, I may I may send you a pointer to something, Meg, after I've had a little more time to to work it. I may send you a pointer and ask for a review. I'm I'm not yet ready to submit a poll request to Jenkins.io because I think I think we've got enough material in the in the contributing to open source document. That we should rather have you review their first, Meg. And I think you've actually already done that. I've done some of that. Yeah, I could do some more. Yeah, so if you get too deep into this, because I want to keep my mind focused elsewhere, but but I can have on a little bit. Well, and that's and that's I feel like Darren and I are already doing the proof of these various pieces, right? Because he and I are doing these and we refer to the document and say, OK, let's read this. And then we discuss it and between the reading and the discussing, if there's an error in the document, we'll we'll detect it. So so I'm not overly worried about that. But before I submit a poll request to Jenkins.io, I'd like to have at least 75 percent of these topics covered in the in the steps so that there's a step for each of them to say, hey, do this, and then do this and then do this. Cool. OK. So that's it for for that topic. Dheeraj, you are welcome to step away and get some rest before you have to start a new working day, even if you can only take a 30 minute nap. That may help you be functional at work today. Yeah, that's not a problem. Sure. So I want to discuss a little bit more on the topic. And I think is I after our previous meeting where you help me set up the environment on my work laptop, I ran some command to like pseudo make run. And I realized I realized that I don't have pseudo permission. So the commands were not running. Many of the commands as well. So. So you shouldn't you shouldn't have to do pseudo. What made you think you needed to do pseudo? Ah, there were some other commands. Like even the Docker command was not running. Ah, and then I would understand. So if if the user, if if you if the building user is not allowed to run Docker, then then you're you're you're locked out. Yes. Because then I started reading a blog which describes how to download Docker and that had a pseudo command. So I realized how it's a loop that I'm stuck. So I followed the same procedure that you showed me and I set up my personal laptop with everything and it runs the site. It generates the site locally. But the thing is, if I go to my aim was to get like to see the changes that you've done on the blog post so far, I'm not able to visit the proper link for that. Oh, OK, so that I can help with. Yes. So. So first step, did you have the correct branch checked out? So let's maybe maybe what we do is let's show the steps there so that you can be sure you see it. So steps mark would include it check out minus B minus T. And then it would be let's see, let's do it this way. And it might be this. It depends on what you name the upstream. So what that does is check out the correct branch first and then make run. And then when you've done that, open local host 4242. And now I've got to go find where the page is just a minute. OK, there we are. And we're just doing make run. So generating the site, local host 4242. And then in my case, because I'm I'm running this on a Linux computer, but I use Windows as my primary machine, I'll switch over here and open up that computers port 4242. And this is the generated site. Now it's developer guide and you should see it right there. So let's put this way, that one. So that URL should should get you there because here you should see this create a plug-in tutorial and adopt a plug-in tutorial. Right. So what if you go to the URL, which looks like after 4242, can you type node, then tags, then tutorial. No, OK, so you're looking at the blog. Yes, this is what I see. But now I know it's the wrong place, but I am anyway curious what this is. Good question. Yes. So undefined method to see him for. That oh, let's see what what do we get? Oh, I know what that is. That's you found a bug in the blog post. Very good. And and that's excellent. That means the blog post is not ready to be published. So well done. Because what this says. Don't you love, Mark, your eyes. Yeah, exactly what this says is we've got we've got an error in the definition of who's in the blog post. So let's let's go let's go see what that error is. Oops. OK, so if we look comparing ourselves to the master branch, did I spell your name wrong, for instance? No, you're or you're let's see. Let's let's do this kit. Let's look at some comparisons to see, because it may be that I've simply got an indentation mistake here in this YAML. And that's why we always can compare something that works and something that doesn't. And how about one that I wrote Jenkins 21 Jenkins and DevOps wrote. Did I write? Oh, no, wiki attack. Let's use that one. That's an infamous one. OK, so comparing the two, I don't see a lot of difference there. OK, so. Oh, oh, yes, I do see differences there. Oh, look at this. What a foolish mistake. So let's look at the differences between these two things so that we can see together what mistake I made. OK, notice that OK, title should be different tags. OK, it's good. We've got tags, except this one starts with a colon and this one doesn't. So there's a first mistake. OK, then two tags. So now if we. Refine the differences. OK, titles are different. Tags are different. But look at this. Instead of authors up at the top, I have authors singular and then list two of them. Right. So that could be a problem. Yes. Now, now let's see if that fixed the problem. So refresh. No, maybe we have to rebuild. Of course, it may also still not be enough. Good, good, good check, by the way. Thanks for finding the problem. OK, refresh. That's better. And there we are. There you are. There I am. And there is a list of steps. Yes. So now what we do is is commit the fix. Exactly. So that I'll be able to have it as well. So we should see there it is. OK, data. All right, now you should be up to see it. Sorry for the disruption there. That it makes it tough to contribute when the thing you're trying to contribute to is completely broken. Not a problem at all. So if I just want to submit a like do some changes from my side just to see whether I'm able to push or not. So what do you suggest to do on a very quickly basis? Add a tech, add a line to add a line to one of these. For instance, I stopped the list at Convert Common API Dependencies. But now if you look in this in this list after Convert Common API Dependencies, there is improved pipeline documentation. Add a link to report an issue that I just added. I think today because I were discovered. Oh, there's a better way to do things. Assign repository. Add one of those and commit it. OK, sure. I can add that. So there is a question again. So where can I find this file to edit? Yeah, so lots of them. Yeah, so the the cheater technique is to get log minus minus num stat master dot dot head. So what that says is tell me the log of tell me all the log entries that are between the master branch and where I'm working now and the num stat says and list the name of the files. So that's the cheaters way of seeing. Oh, there's the file I need to edit. Yes. Now and back to Meg's point, that's terrible to have that be so hard to read. So let's do it this way. So get log minus minus num stat master dot dot head. So from the master branch to the place where I'm working now. And then there is the filing and the benefit of this is now you can go backwards and see. Oh, and here's also this one and this one. And you can see that I'm not up to date with the real master yet. OK, now when you keep your master branch current with the remote master branch, that num stat thing is even more powerful because then it really only shows you your differences. Right. So did that address your question? Yes, I was able to open the file and I can edit it right now. Yes, great. Yeah, well, and and one of the tricks that Darren Pope taught me just during the session he and I were having was this one where I need to remember periodically to go into. Well, let's go here to my GitHub repository for Jenkins.io. And every so often it's just good to hit the see what's a good choice. Let's pick another branch like this one. And then there will be where is the button that says fetch from upstream? Oh, it's it's right here is typically where it will appear. And that gives you give me the changes from the current upstream. So just learn something new, watching Darren do stuff. It was a lot of fun. So it's interesting to use that click on that button whenever you can that you're always updated, right? That's that's certainly a very good practice, at least for me. It's I'm I'm accustomed to managing it all from a command line and that's a lot easier than using the command line. Right. Oh, I forgot, we've got one other topic here today. Yes, Jenkins 2.317 change log. Because we've got a release tomorrow. We have to remember to review that. But we Meg and I could do that, Dheeraj, we don't have to keep you awake for that. Sure. OK, so anything else, Dheeraj? Not nothing on this topic. I'll be sending a PR just to see if I'm able to push or not in the same time. So we can move on to the next one. All right. So next one is and I was hoping to have other participants, the person who I was hoping for did not actually arrive. And so let's discuss it briefly anyway. There is a plug in. There's a series of plug-ins called publish over publish over SSH, publish over FTP, publish over CFS, CIFS that are all based on a core technology plug-in called publish over X. And the publish over X plug-in, this one doesn't have its documentation here. And yet on the wiki, it's got pages and pages of very useful, very valuable documentation that applies to every one of those other plug-ins. And so this is a case where we really need a transition from from wiki to this to this GitHub repository. And it has seventy four thousand installs. Exactly. So it's also a very, very popular plug-in, right? So this is not some orphan plug-in. This is this is installed on roughly one fourth of all Jenkins installations. Wow. So it's it's a very, very popular plug-in. And and so, yes, we should get its documentation. What we need to do is convert this confluence page. Which is a bunch of raw HTML. And now if we want to see how it looks, we can say start. What is it? Publish over five four there. OK, here we go. So this is how it actually looks. But if you look at that scroll bar, there is a lot of content here. And it's it's actually quite accurate and quite useful. So we need this in order to for it to be referenced from these three other plug-ins. So what I propose to the Hacktoberfest contributors, if they're willing, we'd love to have a submission from from them. If by end of Hacktoberfest, we don't get it, I think we need to prioritize this ourselves high. So it's basically an exercise in coding, right? Well, it's yeah, it's a it's a base. It's an exercise in converting from from this layout to ASCII doc or markdown. And I did get a commitment from let's see. So I did get a commitment from Alex Earl. He has agreed to merge. To merge a docs pull request. If we'll review it first. OK, so so that's that's a good sign because that means we want. And I think there's a chance, some chance that that merge will be enough to make it visible. On plug-ins dot Jenkins dot I.O. Where was plug-ins dot Jenkins dot I.O. I don't remember it's here to fix that. Let me say it this way, merge. Maybe enough. So just FYI for everybody. Any any questions or concerns there? No no actions for us to take. I hope this new contributor will will be willing to do it. But if not, then then we'll we'll screw I could be talked into it. I after I get the security stuff done. Yeah, and I think I think the security stuff is is more valuable for us still than than this. Right, and we've got Dan, I mean, there's a lot of security. They're getting the basic stuff done to reclaim what we've got. We'll get that done and then the security will be ongoing. But exactly when you mess with when you mess with structure, you kind of got to dig in and get it all done fast. Right, yep. And you really stuff around, but. OK, so I propose we call that topic done and go on to the next topic, the changelog review for for next Jenkins release. Is that OK with everybody? Sure. OK, so now here we go. Let's look at. Jenkins.io changelog automated changelog for 317. OK, here we go. All right, so bump the markup formatter. OK, I in general, we've been hiding these. I don't think that one is significant enough this bumping a plug in internal version. I don't think that's significant enough to justify changelog for the user. Any any objections? No, that's good. You can hide it. OK, so let's go to Jenkins core. OK, and it was pull requests, pick one. And this one and we're going to market skip changelog. Daniel Beck shrugging. Yeah, we're just going to label this skip. I don't see. I just don't see enough value in that. OK, next. So Mark, the cookie is secure when serving. Oh, this one looks good to me. OK, so this one, the screen resolution cookie. Well, or do we need to change capitalization that so screen resolution cookie has the secure flag set when Jenkins is running on HTTPS. So this is a an enhancement, an improvement to how the thing behaves. So now has. Oh, oh, now has good suggestion. OK, very good. Yes, very, very good. OK, because that sort of sounds to me. I'm sitting there so you're going to tell me what you do. You know, where's the next sentence? It sounds like a lead into something interesting. Right. OK, so got it. OK, yep. OK, good. Is there anything more he had comment? Do we never mind? I'm just shut up. No, no, go ahead. If this done, I should say in the comments above there, I saw something said about there's nothing secure here or something. But I didn't know if there was more content in the comments that should be reflected in the changelog. Yeah, so. There's nothing. It's bad, assuming all cookies are equal. So yeah, so given that this is satisfy a scanner. And and we like to satisfy scanners, but we don't generally have to tell users we're doing this to satisfy a scanner. Oh, OK. All right. So back to. Change log. So we agree that one's OK with the revision to it. Now, this one. OK, that is. Oh, this one needs to change log entries, and this will have to be edited after the fact. Right. So what it's saying is there is the part that's a bug and then there's the part that is an enhancement. And those two need to be two different things. But we really don't have a facility to do this until after until after the release. So what's happening is let's let's look at the pull request. What's happened is there was a there's a thing called WebSocket. And in this thing called WebSocket, it allows us to connect an agent to a Jenkins Jenkins controller that is only speaking HTTP or HTTPS. It's a really elegant trick because we can do remoting over the same port that's serving HTTP pages to web browsers. But there was a problem there with Java 11 and this resolves that problem as by upgrading us to to remoting 4.11 to 4.10. Then in the process, we also had to we deprecated a particular command line option and need to document that we've upgraded to remoting. So the real the real thing is we've got a fix and that's a bug. And then we've got a a what would you call it a an enhancement that is we've taken away this this obsolete command line command line argument. So so I propose we just accept this one for now. And I'll I'll do a fix on it after the release is out tomorrow. Okay, one one question. Could we make this a change long entry being that we've updated this to remoting 4.11 and this has to and then say, you know, this has two consequences. Colon one is it fixes the agent handset and second of all, it deprecates the obsolete option. Could accept that then we've got then we're mixing what they what's been classified as a bug and enhancement and we like to have the two things as separate separate entries. Okay, that sounds good. Do we care that the second one is indented differently than the first one? Well, I'll I'll have to do fixes on that as well. Okay, right. That's setting up now. No, no, it's it's a it's a good point. And I'm not sure if this will render correctly for the initial release of the changelog because I'm a customer of those things being all absolutely aligned. But I don't know how to fix that in the automatic changelog generator. We'll just fix it after the release. Okay, cool. All right, then next one is a bug fix reduce the amount of disc rights to logs tasks dot log. I don't know what. Okay, that that I'm not accustomed to files named log. Just a minute. Let's go look and see what that that says. Okay, reduce them. Oh, oh, it's the asterisk. Okay, got it. Oh, now why did that not do we need to escape it? Yeah, that's what I'm going to try to do. But the oddity there is I don't know why the converter stripped the asterisk, but it did. So good that we reviewed it. We need to we need to chase that down. Be sure in the final that that didn't that damage doesn't persist. Then next one is 5760. And this one looks good to me already. So here's what it says in the changelog. It says display ongoing build and build history regression in 2.314. And lots and lots of reports of this one. So we'll be greeted with great happiness. Okay, then fast review of all the things. Let's see, let's make the text bigger. Yeah, I'm almost tempted to include updated French translation and link to multiple poll requests to highlight that progress because there's been a lot of really good Hectoberfest work on the French translation. But but we don't do most other translations, I guess. So maybe we just leave it. Sorry, go ahead, Meg. What what Angelique always get always gets testy about the French to make her happy if we saw it was important. Yeah, and I think I think it may be worth highlighting. I think so too. Okay. That that's it. Any anything else that you're concerned about on the changelog. So I had a question about though that pull request which will be converted into separate changelog entries. So in this one, as you were suggesting, the procedure is something like this that will be waiting for the changelog to get published on the website and then we'll be editing the automated automatically generated changelog and creating the two entries because since it has been released, so bot will not be, you know, enforcing its changes again. That's why other changes will be holding. Correct. Okay, I just want to cross check that. Yeah, you said it perfectly. You understood exactly what's going to happen and why it's going to happen. That's very good. Yes, you're exactly right. Awesome. So we wait until the machinery is done and then we'll edit it by hand because we can trust that the machinery won't change it afterwards. Right, okay, got it. Thank you. Excellent, good. Anything else on changelog? Actually, I missed most of the things. So did we make sure that every entry has full stop in the end? Oh, good question. Let's check that. Very good. Okay, so this one we removed. This one has a full stop. This one we've got to edit anyway. This one has a full stop. This one has a full stop. So yes, we did. We didn't actually check, but now we have. It looks great. And the other checks we need to do. All right, all right. Then next topics are... So Meg, which of these topics would you like to take first? So we've got your summary of your discussions with Daniel on the security chapter, source structure standard, or classifying wiki pages? Let's see if sort of structure standard goes quickly. Okay, great. If it doesn't go quickly, we probably can't resolve it here. I think it's the only serious disagreement that Daniel and I have. But I guess just the question is, all I found was that one sentence per line thing. And Daniel's gone through all this stuff and we've got these long, long lines. And I, but I think I remember seeing something else, but I think it was something that Liam wrote for Cloudy stuff, where he specified that we try, you know, you try to break things by clause and keep things around any characters. Ah, so, and we've the other, the other reviewers on Jenkins.io, even skipping Daniel will advise, please give me sentence per line. Okay, so that is the standard. It is, yeah. Ugly. Well, actually, I confess it's been very helpful for me because it is an immediate detector of run on sentences. Ah, I look at, I look at, I've got, I've got a relatively wide screen. And if I ever wrap on my wide screen, I know that I'm clearly run on. And most of the time I'll think very carefully if I'm much beyond 80 or 90 characters, am I running on? Have I put three ends and several, several commas in this thing that I shouldn't have? Yeah. Joyce, you can tell the people, the people who work with line editors like VI, like the shorter one. But yes, I've been accused, somebody looked at once and said, your source code looks like haiku. And it's like, well, so. Right. Okay. So I lose that one. I'll have to suck it up and do it. Okay. Let's do the classifier and then I'll, I just copied you on the incomplete document where I'm summarizing what we're going to do for the structure. Oh, okay. We'll do that later. But I got, okay, those, we ran into, we've got a bunch of wikis referenced in this stuff. And Daniel is going through it says, well, that was never here. That's a Python thing. Do it like you do in Python and Jenkins will recognize it. We shouldn't have, we shouldn't have anything on that in Jenkins IO. Other, a couple of others said that's a really, really narrow band of users that use it. It shouldn't be in Jenkins IO. But I got, and then he said, well, you know, I'll go through them and tell you what you, well, there's all, he doesn't know how many there are. He's not going to get, but I got the, let's, let's say that he starts going through. What is the mechanism for that? And the best idea that I had was to put a little checklist at the front of each, at the top of each file for each wiki that's in that list, where, so it would be, you know, the dispensations, it could be, you know, this is worth converting as is. This is a good topic, but the content needs to be rewritten. This doesn't belong, you know, a couple of those. That, and that somebody could go through it in the market and then have a comment and they, and put the author who did it. So we could look at it and say, Daniel Beck says this shouldn't go. And a place for a comment. So then somebody could say this was incorporated into the user guide in PR, such and such, or, you know, or whatever at, you know, comments are always handy. But would it, is there any way to do something like that easily so that then when you generate your list, you could search on that and it would knock out anything that had, you know, that somebody had marked as, don't do this, let it die. Yeah. So I think, I think if someone's willing to do that kind of a thing, if they were, for instance, to insert an ASCII.com, which is two slashes, or four slashes, if I remember, yeah, you can do two slashes for a single line. And then say, give their statement on the disposition of it, right? It's wiki.jankins.io slash jankins slash distributed builds is flawed but worth keeping. But worth rework or it might be. If they're doing that free form, there's going to be typos and you're going to have a term of working with it programmatically, aren't you? Well, but, but I'm much less concerned about the programmatic work because the most crucial thing here that we gain is understanding what to do with the thing that is a broken link today. Right. And so, so the, for me, the real benefit there is the real benefit there is that someone has looked at it and put this comment. And then when we, when we're able to address it, they can, they can then say, all right, we've addressed this by and delete the comment that says, hey, such and such as rubbish needs complete replacement, completely right. Or this topic should not be in jankin stocks. Right, exactly. Irrelevant, right? And maybe that's the better way to say it is irrelevant. And that's our way of declaring should not be in the docks at all. Well, I think there's, there are two, one is the topic, the topic is good, but the content is rubbish. Right. The other is that the topic is irrelevant. Oh, yes, very good. Topic is good. Content is flawed, but worth rework. Right. Or it might be, and I think we've already got most of the ones that fit this next category. ABC, topic is good, content is good. And there it's just copied in then. Another thing, what I can see is even if Daniel hadn't made this offer, which I know he's not going to be able to completely come through in, but in doing this, we're hitting actually this one, we've got eight or 10 links that we look at those and there might be a couple of them that I would mark and say this was incorporated into Jenkins IO with this PR. Well, see, if it's been, if it's been incorporated into Jenkins IO, then we should just delete the reference to the wiki and hyperlink to the Jenkins IO location. Okay, but then when you list out, we list out the repo that's got all these in and I look at that, how do I know that somebody's already taken care of this? Oh, you don't have to. We use, I think we should use Jenkins IO as the source of the information here to decide which things we bring in from wiki. As the first choice is, oh, bring this from the source if it's referenced on wiki.jankins.io. So now if it's not already referenced on wiki.jankins.io, then an ASCII.comment won't do because the source document is not ASCII. I'm making it clear here. So yeah, that's right. I was thinking of inserting something into those files. Oh, so you were thinking of inserting something into the HTML files. Right. Okay, so and that would also work if we're doing that, annotate the source repositories, annotate the Confluence data files with the same type of info. That would be great, but that's almost 3,000 files. Right. That's why I'm thinking, but if I look at one of them, if Daniel looks at one of them and is in there and has something to say, if we made it really simple for him to record that, it would be recorded. And if enough. Yeah, yeah, it could insert the same annotation as an HTML comment. Right. And I'm thinking about putting the boilerplate for that HTML comment into each trial with a note about if you're looking at this and you have something to say and it would be all they would really have to do is mark a checkbox and give their name. Yeah, so that I'm hesitant to do just because, well, we certainly can. It just feels like that's a recipe for lots and lots of, I'm not sure what they'll get from it because I don't, as I think about who's going to review those files, I don't think there are many of us that will review them. At least if there were a lot of people willing to review them, I would have expected there were a lot of people willing to help us migrate them. And that's not been our experience. No. So, but it's, I think it's worth asking. It would, I'm thinking it would be, it strikes me, it would be harmless if nobody uses it. And I mean, even a few of them, it might save some duplicate. If, if you look at, you know, if Jesse Glick looks at something, he can say, oh, Daniel Beck already marked this is irrelevant. Yes. I don't need to worry about it. Yeah, well, it gives us a history, especially as people as the staffing changes, etc, etc. But I don't know if it's. Then isn't it that we, we probably don't even want it as a classification comment. In that case, we probably want it because right now those, that confidence data is, is for me largely unusable because it's rendered as raw HTML. Right. I'm not seeing those files as their actual content. I'm seeing this HTML markup that I just really struggle to read. Yeah. What I would want is, go ahead. Yeah, I want Mark Downer, ASCII doc or. Well, render it as HTML and show me, show me a way that I can see it. Right. I'd like to see something closer to here. Let's take this file as our example. No, let's take one that I care that matters to me. So let's pick here we go. Ace editor plugin. Yeah, this is a good one. All right. So if we take that file name and in this start, this is how it actually looks. Right. I think if we wanted a comment here that somebody had visited this, it should probably be visible in this view of the file, not just in the peer HTML. So rather than a comment, it would actually be some, you know, a heading down at the bottom that says classified by so and so, or not yet, not yet reviewed. I agree. Yeah. So how did we, because let's okay, let's say that one of these, the information is good. It's a good topic. And I say, you know, I was linking to it here, but I'll just move it over to Jenkins IO. To me, it looks easy to take the rendered and copy and paste the text and just put the ASCII doc stuff in. I agree. For me right now, that's, now there is, there is the wiki exporter. So there's the Jenkins wiki exporter here, which may be able to help us because I think it has, whoops, I think it has a facility to take general, a general purpose webpage to do wiki export. Let me see though. Okay. This is export Jenkins Confluence wiki URL. Don't know if that, I don't know if this thing works anymore or not. So this, I would suspect it won't like me giving it this file. No, yeah, it doesn't. So it's, it's got sanity checks in it. So we don't have anything that will do the markdown conversion for us right now. But I think if we ask nicely, we could probably persuade Gavin Mogan to help us with that if we need it. If we get lots of requests for the short term, for me, it's easiest just to read this HTML and paste it into ASCII doc. Yeah. Okay. So did that, did that address your question there, Meg? Still don't know exactly, I still don't know exactly what we do with one of these. Whether, you know, just, you know, if, if we look like last night, Daniel and I are looking at it and I would have loved to somehow or rather quickly mark the file that Daniel had looked at this and said such and such. But that may not be useful. That may just be me. Well, but I think, I think it's certainly that could be done, that can be done. If we can get a reasonable way of getting these pages into a an HTML site like GitHub pages, then we could possibly just have a hyperlink at the bottom that says edit this page and you click edit this page and it drops you into the GitHub editor and you put a comment at the bottom of the file. That would work. Hey, we reviewed this and it could be as simple as plain text because plain text renders just fine in HTML. That would work. And then maybe you don't need this, would this put you in a position where eventually you could have your list of wiki pages that still needed work that would get to be a smaller size? Right. Good. Yep. So Meg, I'm going to pause for just a moment. We're almost out of time and Dheeraj said he had one more topic. So we're about one minute from end here and Dheeraj, what was your topic? Yes. Thanks. So I noticed that even after having Hacktoberfest label on the PR, it's not still being counted and then I went to the page and read the rules and I think it says that if the project is not participating and you want your PR to be counted, you need to have the label called Hacktoberfest-accepted, I think. Even when it's merged? Yes. Oh, okay. All right. Well, so then we better get that noted. Thank you. Thanks for the pointer. Thanks. So should I message on the PR to the container that came in? Yes, please. Hey, apparently in order for it to be counted, it needs the Hacktoberfest-accepted label. Sure, I'll do that. That's it. Thanks. Yeah, thank you. And they could also, they can either assign Hacktoberfest as a topic. To their plugin repository, right? Right. Or they can label as Hacktoberfest-accepted. Yeah. So could you double check with Rajan Singh to be sure that his pull request was accepted, the change was merged, et cetera. You just want to be sure that it was correctly credited to him for Hacktoberfest. That's a good idea. I'll check with them today and we'll comment accordingly. Thank you. All right. Thanks. Anything else before I go get some sleep? And before Dira should get some sleep and probably won't. Yes. Yes, that's good. Yeah, just that Daniel and I are at peace. Yeah. And I just copied you that the Google Doc is not complete and it's not being written really for public consumption. It's kind of high level to keep us online. But if you want to see what we're up to. Okay. And that's that's the security chapter organization discussion. Right. Excellent. Thanks, Meg, so much. Any input? Very welcome. Well, thank you. Thank you a bunch for doing that. Deeply, deeply appreciated. Oh, it's been bugging me for forever. So I'm glad I've got a chance to do it. So. Oh, thank you. And I love, I love working with, you know, we had this little thing. We should talk. And so I'd kind of written to him. I said, well, I can do it any morning this week, your time. And, you know, about 1130 last night, I was fixing dinner and again, you want to do it now? So I turned off the stove and we did it. So all right. But on the PRs, there was kind of this give and take this. It wasn't meshing and but as soon as we started talking, we both were pretty much have the same mindset. So it was pretty easy to put it together. So very good. All right. Thank you very much. So I will we're going to end the session and I'll post the recording eventually. Thanks all. Okay. Thanks everyone. Thank you so much. Bye. Bye. Bye. Bye. I knew how to drive this end button. It's just determined.