 Okay, so recording is on welcome everyone it's Docs office hours it's the 30th of August. Sorry, it's the first of September in India standard time. And 30. Is that right or is it 31st of August. No, it's 31st of August 31st of August India standard time and and be good to each other we abide by the Jenkins code of conduct. So the topics that were on my list were review the 2.309 automated changelog and propose improvements to the 2.308 changelog. So this is this is our first experience with the changelog automation. What we have is we've got and I'm going to share my screen and let's look at what we've got there. So what we have is a this is GH PR list so the poll request is 4525 and if we look at it what it comes in automation wise. What is it looks like this, and there are comments there, but there are things inside this poll request or inside this is what it looks like when rendered on screen so no proposed changelog for 5682. And I think that means we really need one or we need to list it as skip changelog. It doesn't show skip changelog. And Oleg says the changelog looks good. Oh, but this is not. Okay, so what we need to do is we need to adjust this one to because the changelog automation didn't get it correct. We need to fix that so that this will have a proposed changelog. Now one way to do it is probably to insert the text. Now, I don't know which to do. Alright, I, I mean we could insert the text into this. That is the boilerplate for a changelog. Let's see, let's see if we can grab one that has. Yeah, so propose changelog entries. Let's grab this so comment comment propose changelog entries proposed upgrade guidelines. So back to this one we could do this. Now we need to go find a similar poll request. Okay bump JNA from. Okay, so 5682. So what we're looking for is the text of 5682. Okay, so here's whoops. That didn't help me. There, here's an example. Okay, so how do we get the automated changelog to have that content. Any bright ideas. We could edit the YAML file directly, but then the next run of the automation will probably wipe out our, our reference. I guess that's still likely the most effective way to do it. Till I get a chance to talk with. Okay, so it would be here. And this would then be 5682. So. Sorry, go ahead what was that. So the automatic changelog does not add this references type right by itself doesn't seem to at least as far as I could tell. And we want to add that. Well, so that's what I was thinking. And now the question is, should this thing. It was categorized as developer, and that makes sense to me it should be a developer changelog. So that's what I was thinking we should do say all right it's an RFP developer so we need to put it at the bottom. So that is PR 5381 is that the correct pull request. No it's 5682. There we go right here it's references a link to the changelog and let's test that that the link actually works. It did. Okay, good. So the other alternative would be, I mean I would hope that someday the automation would be able to generate those kind of reference links for us, but it certainly didn't this time. Also side issue should we spell out Java native access or is that really that commonly understood. Where would you like it spelled out here in the title. Or, yeah, or either the title or the description, you know you could say bump Java native access parents JNA. Like maybe it's maybe it's just my ignorance but yeah I like that. The challenge is it's a library and libraries that that's a that's a generated string from dependabot but I think you're right it's certainly clear to the user if it's, if we do that instead of just using the in the bat short name. Got, I did search the bank and diode doc and didn't find any real information about it so. Okay, you know, there were a couple of other like changelog things in there or something but there wasn't anything explained what it is or why I care. Right, right. And yeah, I'll shut up now. No, it's good, good feedback. Very good. Okay, so the next, go ahead. Yes, so I was just wondering, maybe while writing the automation script, we can do things like whenever we come across a developer category entry, we would want to insert a references tag. And in that we can directly put the value of pool as the pool that we have received previously and URL will be. Oh, URL cannot be automated easily. I don't know that's I think it's a good question because it might. Let's look at the source code for this because that URL may be in here somewhere, and we just have to look for it. Okay. So the word release occurs twice. No, I don't. Okay, so I don't see a reference to the tag but let's look for other. Okay, so there's a poll request bug fixes commits. See, I don't see a reference to the release. Maybe I'm just not looking well enough. Okay, in the changelog. Yeah, see this. Oh, there it is. Okay. So here is the link to the changelog. But what it lacks is it lacks so so there is a link here. So considerably the tool could could extract that hyperlink that is in here. Let's let's look at it now. So this hyperlink right here could be extracted. Now why don't we link to that in. Oh, we do. That is exactly what we're using. So we just need to append the release the latest release number at the end right. Yeah, yeah. So if this had been release something. Yeah, where was it if this had been released dash 590. It would have been directly usable. And it's it's still usable even even without that release dash 590 90 so when I expand this if I open that in a new tab. It takes me to the exact same right place so so conceivably this could be used. And then this link would just have would not have the release 590 and it would just be missing that part. Okay, so there's there's I think there's good potential there. Now, now there's another one here this one. So the second one on the list is this RFE internal. And it appears that it's inserted the word internal twice. Let's see if I can see it so see this internal internal. I assume that's the generator, putting the word internal and then the original description had the word internal as well. So here, one thing we could do is change this text. Now, on the next run that will remove one internal. Okay, what is PR. Okay, I'm missing something here. One thing. Oh, go ahead. What's that. So I asked about PR title to Tim job. So he suggested that he says that it's, it doesn't do anything. It just came from the Jason, because I was also curious like where are we using it so we're not using it anywhere. Okay, so it is not being used. So the change there won't help changing it to not use the back quoted markup won't help. Okay, good. All right. And this one is used and it's using the correct HTML markup. Okay, so aunt class loader. Yeah. Okay, good. So we've got an entry for 5682. And we've got an entry for 5687. Now these two are both developer and internal so they actually belong at the bottom. And now I'm going to reload that whoops wrong. Reload that page. Nope, not that one. Reload this page. It says add a boarded threshold fixed missing settings here's bump Java native access with its hyperlink. Yes, good. Okay. And this one is poll 5687. And it works. Okay, good. So now the next challenge is this one right here with the embedded picture. And the regression in to do. I think I don't know what to do with this one because the automation has placed the before and after, I think what we ought to do here is just move the before and after picture. Whoops, move it outside of the proposed change log entry. For example, if it were placed here, the next time it runs. There's the before there's the after and here is the so like that. Okay before after and then now the proposed change log entries the next time that job runs. It would get it correct and in the interim we fix it by removing that image stuff and the regression in to do is where is it's fixed it's logged as a regression fix but the version where it regressed is not. Okay, so where. Where was the bug report, because this doesn't tell us which version had it so do we just make a wild guess. It was. Oh no no we don't have to make a guess at all it was a change previously that modified icons right. And so we should be able to find it here. Nope. Okay. How about something from the same author, Jan Farachuk. So there's use the SVG version of the text icon so probably 2.307. Okay, so let's guess 2.307 seem reasonable. So, alright back to look at what our draft looks like. And it says add the aborted threshold to reverse build trigger fix the missing settings cog icon and plug in manager fix incorrect folder icon, showing in projects regression in now how do we usually lay out the regression in. Yeah, it's parenthesized right before the issue that's being right okay good so that's consistent. And here bump J and a 58 to 59. And then internal class loader and it's subclass register themselves as parallel capable what do you think is that acceptable. Yes, we have internal at the end and links are working and the co the highlighted ones are there and full stops are so you don't have full stop the first one. Oh, we're missing full stops on the ends of lines. Thank you. Good reminder. Very good and our, our contributors in, in China very commonly alert when there is a full stop missing online. Thank you. Good catch. Okay, so I think we got full stops everywhere. Let's check it one more time. Full stop there full stop there. Yep. Okay. Anything else you see that's a mistake. The fix missing setting icon is it's a bug right. It, it is that's correct. And the first ad about it is, is just an RFE. Also correct right. So, I might, I might be confused right now but shouldn't bug be forced or it's only when we talk about major bugs and no it's it's a good point because so in 308 RFE's proceed bugs. In 307 bugs proceed RFE's and 307 was the one we edited by hand right and it looks like all the previous ones we've had generally had bug precede. Well, no, yeah, this one is major so it here, here's an RFE. No, and no let's find a different. Here's a bug. No, that's a major. Come on I need something that's got same level. Here we go a bug, not major preceding an RFE so I think you're right we should move the bug first, like this. Okay, so we've got the bug fix missing icons. And then we've got the RFE. And then we've got a developer and issue and then an internal. Okay, back to looking at how it looks. Okay, fix missing settings. The bug, then the RFE, then JNA and the that's a developer one and then the internal one. Okay, so far. So which one is developer one. This one right here. Okay, so do we not need the developer semicolon. Oh, we do. And we've used developer before so yes it should say developer shouldn't it. Absolutely. Yes. Very good. Okay. Let's try that again. Thank you. Nice catch. Okay, whoops, except didn't. Okay, now we've got the keyword developer. And the keyword internal. Now one of the things I wanted to check was is that all of the pull requests that have been merged for this release. So, Oh, except that have those that have skip changelog so updated at since that's a skip changelog. Bump mosquito core. This one is, is it closed. Oh, it's closed. You're right. So this one was rejected. Okay. Whereas fix missing icons we've seen this was also closed. This was approved and we've seen it. Bump X stream was closed. J&A is in the list. Spotless is skip changelog and palm dot XML is closed. This is skip commons IO was already eight days ago so all of the pull requests that I see here are represented in this list in the list here. Okay, and now we've got three that are listed as comments update at since spotless plug in and automate the changelog. So I think we're ready to submit it. What do you think. I think so too. Yes, it looks good for this Java native access of 5.9.0 changelog. Do we need to capitalize and and a Where here above this above this. Oh, I see what you're saying. Good point. This one. Yes, this one like that. Exactly. And that's, that's different than we've done it in the past but I think it's consistent. Oh, with Meg's observation that Java native J&A is It is tough because usually you'd make the acronym all uppercase but if it's actually a library name. Right in this case because it's a library name I hesitate to make it uppercase. And I'm even actually called J&R is it got a suffix of some sort. No, no, it really is just called Java native access. It's certainly delivered as a jar, but the library name is Java native access so if we look. If we look at the other occurrences in this file of J&A You'll see sometimes it was rendered as all caps. Actually, it looks like it was consistent. Oh right and we expanded it. But it was done here as all caps in the title but then here always rendered in a path name. Right. Exactly. There's one where just Java is uppercase and still native access. So, so do we want to just write J&A 5.9.0 change low or something else. Yeah, I think so dear Raja I think what you're saying is should we put this to be consistent with the other entries. Yes, because here it uses J&A 5.4. And the argument in favor of that is we've already expanded the acronym here on the line. So having done that this will look like this. Let's take a look at it. So it says job bump Java native access and then here in the hyperlink is where it uses J&A. Meg, I believe it's considered okay to expand first and then use acronyms later. I think so. Yeah. Okay. Outside of check I think that's a standard in check it's weird. All right. Okay. Anything else we need to change. 2.308. We're still on 309. We'll do 308 as a separate set of fixes. So everybody okay with me committing this one. Okay, yes. Okay, now, now this one will highlight a complication for us. I'm going to push something. Oops. But Deraj, for instance, you won't have permission to do this because I've got permission to write to the, this repository. And so when I say get push, it's actually going to push. See, I've got it. I've got to make that commit message better. Okay, so now if we say get push, and it says the upstream does not match your current. Why not get push. Oh, that's fun. Yeah. Oh, no. Okay. Not sure if I'm going to be allowed to do it so we may have to find another. Okay, so it's not so we've got this problem we've created the changes. But now how do we how do we communicate those changes to others as a proposed change to the poll request. See, I can't do a push because it blocks the push because I assume the depend about didn't does not allow others to push onto it. So how was it done last week. I don't think it was done I well let's let's that's good question. Let's go look. That's a very good question. So, give a link with you in the chat. Oh, you do. Okay. Yes, very good. So let's go grab that link so here is the this is a link to the change log. Okay, so they proposed. Okay, I don't see any edits to the change law. Here's the initial commit. I don't see any edit so as far as I can tell they didn't do any edits. So I think what we we we've got to experiment with is, how will we edit this thing. And so if we did it, well let's let's try an idea. What if we did it like this what if we said, here's the automated change log. And we are going to. Okay, so I need to see the files changed. I do not understand that one, but I don't care this is the one that I want to make. Well, how do, how do we approach it. Okay, what if let's try one, one of them. Let's try fixing this one. Okay, so just making a wild attempt to fix this one by proposing it as a suggestion. I don't know if this will be acceptable to us or not. Let's try it. Okay, so here is the text that not where was it. Okay, this is that embedded fix missing icons. So it's this one right here. Right. Okay, so that's what we are proposing should be changed and our proposed change looks like this need to remove the image from the change log file. The image is from the change log file. Okay, so here's our proposed. The trouble is that that works fine for this one that stays in the same place. It doesn't work for a case where we need to move something from one place to another. I mean, I guess it does we have to do a delete and an insert then. And that's really kind of painful. Let's, let's, how about let's try this technique and see if we can, if we can see if it's tolerable. Okay, so this one, I think was not changed right the modification from mods Jacobson, where did it go. Jacobson this one, we didn't modify that, did we just a full stop. I think. Okay, so then let's go to. So we've talked to cover these are now this one. Okay, so this is the JNA one. Now the problem is Jenkins 5682. Okay, so what what Tim says we should add a change log entry to that. Okay, Tim says need to add to this if so, which to me says he's expecting us to put in upgrade guidelines but I don't know how to make the upgrade guidelines create a reference. So let's do. Well, back to the question how do we create a poll request that has this content so proposed change log entries proposed upgrade guidelines. Alright, so proposed change log entry was, we had it right here didn't we propose change log entry was this, and no upgrade guidelines, nervous not having that right there. So here's the proposed comment and proposed upgrade guidelines. Does that make sense in terms of trying to do what Tim's recommending here. Thank you. Okay, so still for me, it'd be much clearer if we just insert into this thing. Our proposal, we think it should be this. So the reason why you edited the message for that pull request in the next step is because so that the generator can take it from there right. That was that was my hope I was actually just trying to follow Tim's advice. And, and I'm not sure which will win here right it may be that our proposed edits will win. It may be that instead the tool always copies from from the original and therefore our edits will be completely discarded. And I don't know which will actually happen. I think it will copy from the original maybe. Yeah, that's, I think, I think you're probably right. I just don't know if I am not not certain. Type category developer authors. Okay, so we should insert right above references at PR title. So PR title bump DNA. Okay. So this is one experimental way to see if we can, we could make it honor our change. But this didn't put it in the correct location. Okay, back to where we were let's go on to the next one that's this internal one. It is it all the way at the end. No, it's somewhere earlier. It's right here. Okay, so that's what we had proposed as the text for it. This is saying internal code and class loader. Okay, now I'm not sure what what I'd propose is let's try this as a test drive. And what I'm going to do is I'm actually going to finish the review and then go ahead and commit the suggestions. Now it may be that that needs the changes we've proposed. And so I'm just doing it as a comment submit the review. Now I'm going to actually go in and add the suggestions to a batch. I have to use the right view. Add the suggestions to a batch. Okay, now I'm going to commit the suggestions. I think it will allow me so apply code review changes. Mark, wait. And make McRoberts. Whoops. Now why did it not get rid of refresh. This should have gotten rid of that image stuff which it did. Okay, so now. Okay, so, and I have to delete. Now if we do a GHPR check out. So now let's compare this and this. Did we get everything okay what we didn't get was we didn't change the ordering of things. And we lost the PR title here in that change which you had said is actually not preserved so that should be okay. Yes. So the next thing we need to do then is we need to change the ordering, and I'm not entirely sure how to do that from the GitHub interface. So what we're what we need to do is we need to delete this developer RFE and this internal. We've got to do this. Okay, we've got to take this one here. And so cancel my unskilled use. Okay, this needs to be marked for deletion. Whoops. Nope. Like that. And then it needs to be inserted here. Does that make sense? Yes. Okay, so I think this is a terribly painful process way to edit the change log. But let's try it and see if it works. So we're going to finish the review. What's that Jacob, Jacob's entry. I think we didn't put the full stop in the end. Oops, oops. Okay, what did I miss? There's an entry by Jacob, as you mentioned about this one about it code threshold to reverse trigger build in line one two three nine seven. So this, oh right, you're right. I see what you're saying. This one from Jan Farachik needs to move up above this one from mods Jacobson. You're right. Did I understand your your observation correctly. We might need to look at the ordering but I was specifically talking about line number 12397. Okay, this one. The full stop is missing, I think, right. Oh, the full stop is missing. I see what you're saying. Yes. Okay, good. Right. You are correct. It is. Got it. Okay. All right. That's a thank you got that. But I think isn't even worse that we've got an RFE first and then a bug and I think what we observed is the preference is bugs first then RFEs. Yes. So this thing needs to be deleted from its current location, and it needs to be inserted in this one at the very top, like that. Okay, so what that says is bug. In the top RFE full stop added full stop added bug moved up. And then developer and internal. Okay, so I think we're ready for just locations of bug items. Okay, and now we're going to have to do the same trick again of add to batch, add to batch, add to batch, add to batch, and now commit the changes from the batch. Reorder sections 2.309 change look. Okay, now back to our command line. Let's see if it. Okay. And now let's try a diff. And the only difference there is we didn't carry forward the PR title and we added a blank line. So if I do a make run, we should be able to see it. And it should look correct. This was a terribly painful way to do the task. Okay, I think it is still showing us what we wanted to see. But we were relying on my permissions to make those kinds of edits. I think what I'm going to have to do is talk to Tim tomorrow to see how he envisions this being edited. So it may be that what he's expecting is that we'll go edit the pull requests, and make them better somehow. And then the tool will automatically read from the pull the improved pull request description. So do you want to run locally and do the edits or do you want to edit directly on the PR that is on the repository. I think we would prefer to run locally but I don't know how to push the changes. Once we've run locally. Yes. So it doesn't make sense to eliminate the part where we don't have to run locally right. So you won't be able to see what is wrong and how does it look like eventually. And I don't think we can eliminate the run locally because without the run locally we would have missed that there was a picture at least I would have missed that there was a picture embedded in the changelog. Right. Yes makes sense. Now, now, better editing of the changelogs. Better better yeah better editing of the commit messages can avoid that but humans are human and they make mistakes. So this one I think I think 2.309 is is reasonable I think we're ready to switch to look at 2.308, but I apologize we've largely run out of time. Would you like to try something similar for 2.308 and propose it as a separate poll request. Do you do have time to do that or is this have we run out of your time as well. I mean right now or offline offline, I was just thinking offline without without so if if you've got capacity to do it, I would love to have someone else attempt and edit otherwise I can look at it tomorrow you know in the next 24 hours. Right. So since this has already been published already been published on the website. So it's just a practice for us right to edit it. Well it's it's not not just a practice in that I think this changelog is really bad right I think it's this is this is a changelog that we want to fix and and but we can do those fixes just by proposing a poll request to repair it. So it doesn't have to this doesn't require any special permissions, you can do it I can do it make it do it anybody could do that poll request. Okay, so I'll try today. Okay, well and and if it doesn't work out for you or you run out of time don't hesitate to stop will I'll I can take a look at it. Just post a message in the in the getter chat. Hey, ran out of time. Yes, and also I was having some problem with generating it locally due to GitHub issues I don't know why. So, if that doesn't work, I'd like to know as well. Okay, also, yes, if if anything blocks you don't worry about it just note it and and if I if I haven't seen a poll request from you by end of my day tomorrow, I'll probably work on it anyway. Okay, sure. Gitter or IRC. Either is fine. Either either is fine I have to check both of them so whichever one you're in use that one. I'm mainly active in IRC IRC is great then good choice. And last question is, should I be texting you on any channel because I'm only on Jenkins release or should I DM you. In fact Jenkins release is perfect because that's one of the two IRC channels that I monitor, and it's a low traffic channel that Tim sees so so it's a very good choice as far as I'm concerned. Awesome. So I'll text you there. Great. Great. All right. Thanks. Time to say goodbye. Well thanks to your eyes and thanks Meg. Thank you very much. Go ahead and stop the show and we'll call it done for today. Yes. Oh, right. I'll buy some notes. Thank you. See everybody.