CS:S Color Correction Bug

This is a bug in Counter-Strike: Source that will disable a maps color correction for every player if the player with the entity index of 1 leaves the server.

What's happening in the video:
First a bot is added to the server so they are assigned entity index 1. Then I joined the server so I'm assigned entity index 2. When I kick the bot you will see the color correction is disabled since entity index 1 no longer exists. When I re-add the bot the color correction is enabled again since entity index 1 is back.

Why this happens:
http://hg.alliedmods.net/hl2sdks/hl2sdk-css/file/ea2180997646/game/client/c_c...
Looking through the color correction code you will see at line 125 a function call like this "UTIL_PlayerByIndex(1)". That is trying to find a player with the entity index 1. If no index is found it will return and never call "SetColorCorrectionWeight()". Line 125 should probably call "UTIL_PlayerByIndex(engine-GetLocalPlayer())" instead. I don't think this is the exact CS:S code but I'm guessing something very similar is happening.

How to reproduce:
1) Find an empty server on a map that uses the color_correction entity.
2) Have a friend join that server first (entity index 1).
3) Join the server yourself (entity index 2).
4) Have your friend leave the server, you will notice the maps color correction disables.
5) Have your friend rejoin the server (reassigned entity index 1), color correction will now be re-enabled.

Category:

Gaming

Tags:

• css
• counter-strike
• source
• counterstrike
• cs
• bug
• bugs
• color
• correction
• color_correction

[Arez87]

DUH

[bergman97]

i dont get it

[Tonester46]

you're a cs:s color correction bug !